search

dev-cafe / parselglossy

Generic input parsing library, speaking in tongues.
https://parselglossy.readthedocs.io
MIT License
7 stars 2 forks source link

Refactor tests #25

Closed robertodr closed 5 years ago

robertodr commented 5 years ago

Generation of test cases can get a bit unwieldy, given how many different "axis" there are. Hypothesis can help quite a bit and we should refactor other tests to use it.

bast commented 5 years ago

Also consider using parametrize instead of a for loop for checking of type errors.

robertodr commented 5 years ago

I have done some of this in #42, but there's still ample room for improvement, I think. For example, we could have a set of fixture components and then generate test inputs and references using Hypothesis to randomize the test cases.

robertodr commented 5 years ago

Some data regarding lines of code (obtained with cloc) in folders parselglossy and tests. Screenshot from 2019-03-26 13-46-58

bast commented 5 years ago

Roberto did already a lot. Closing this issue since we will improve this continuously.