dev-cafe / parselglossy

Generic input parsing library, speaking in tongues.
https://parselglossy.readthedocs.io
MIT License
7 stars 2 forks source link

Improve formatting of documentation, fix #49 #52

Closed robertodr closed 5 years ago

robertodr commented 5 years ago

Documentation looks a bit nicer and fixes the repetitions @stigrj noticed with multiple keywords.

Screenshot from 2019-03-27 12-41-35

stigrj commented 5 years ago

Looks great! One more issue, though:

Long docstrings are linebreaked in the input.rst file, which leads to the following message using rst2html.py input.rst >input.html

input.rst:459: (WARNING/2) Definition list ends without a blank line; unexpected unindent.

which also ends up in the produced html. The warning goes away if I manually unbreak these lines.

robertodr commented 5 years ago

How long is long? I cannot reproduce this.

stigrj commented 5 years ago

Hmm, turns out it line breaks at the same place that I do in the template.yml file, like this

    keywords:
      - name: numerically_exact
        type: bool
        default: false
        docstring: |
          This will use MPI algorithms that guarantees that the output is
          invariant wrt the number of MPI processes.
robertodr commented 5 years ago

OK, I see now!

robertodr commented 5 years ago

I now replace newline characters in the docstring with spaces, so the string is stitched back together. Final formatting could be a bit crappy though, as very long lines will exceed their box... I'd leave format beautification for later though.

codecov[bot] commented 5 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.01%. The diff coverage is 100%.

codecov[bot] commented 5 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.01%. The diff coverage is 100%.