Closed robertodr closed 4 years ago
I understand this is a draft pull request?
+1 for the suggestion to make parselglossy a generator.
Yep. It's a draft. I just forgot to mark it as such.
As to CLI I would find this (--target
or --output
, --from
/--input
):
$ parselglossy generate --target /my/path --from template.yml
more intuitive than this (we are not generating template.yml
):
$ parselglossy generate template.yml
Agreed on the CLI. Will do that in the next few commits.
All pieces are in place and tested. It need to be documented, but the code is ready for review.
It's now documented :confetti_ball: Please squash-merge. The commit messages are really bad :)
I thought I could force-merge but this is disabled. Should we take out macOS builds, open an issue on that, continue work, and reintroduce them before we "release"?
Agreed.
On Mon, Jul 6, 2020 at 9:28 AM Radovan Bast notifications@github.com wrote:
I thought I could force-merge but this is disabled. Should we take out macOS builds, open an issue on that, continue work, and reintroduce them before we "release"?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dev-cafe/parselglossy/pull/84#issuecomment-654064755, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JOEIXAOJRPHXU5VH57CDR2F4I5ANCNFSM4J66VDNA .
-- Roberto Di Remigio
OK I will take care of that.
They're still reported as "expected" in the checks because the main branch has them in...
OK, now green :)
Maybe you can try minting a new tag and seeing whether the deploy action actually works? I even wrote instructions on how to do it! https://parselglossy.readthedocs.io/en/latest/contributing.html#deploying
Still stalling on the builds. I will check whether I can give myself temporarily more merging power to get this in. The deploy action can be tested without creating tags, somehow I don't like to create tags just for testing.
Now it's green also on my side. Weird, some leftover. Merging.
As discussed at length since the first few releases, I'd like parselglossy to become a generator for parser and documentation. High-level usage:
output:
Main goal is to have zero dependencies for final users. The CLI is generated with Argparse, while
pyparsing
is shipped with the generated files. This protectstemplate.yml
and the grammar from accidental tampering.