dev-cafe / parselglossy

Generic input parsing library, speaking in tongues.

https://parselglossy.readthedocs.io

MIT License

7 stars 2 forks source link

Use Flit for packaging, close #92 #93

Closed robertodr closed 4 years ago

robertodr commented 4 years ago

The GitHub deployment action needs to be done too.

robertodr commented 4 years ago

Now failing horribly because I didn't adjust the testing action :facepalm: But the installation of the script does work now!

bast commented 4 years ago

Should I take it from here and adjust that or are you working on it?

robertodr commented 4 years ago

Working on it

codecov[bot] commented 4 years ago

Codecov Report

Merging #93 into master will not change coverage. The diff coverage is n/a.

robertodr commented 4 years ago

@bast Ready for review! The deployment was copied from xcauto, but is still untested.

bast commented 4 years ago

For the deploy step I think we should use https://github.com/dftlibs/xcauto/blob/master/.github/workflows/package.yml unmodified. It is well tested.

In particular:

We should use an API token instead of user/password (perhaps this is already the case)
I don't think we should run the deploy step on all Linux, macOS, and Windows, it will fail on 2 of them. We would need to run it on all if we wanted binary distributions but here it's a source distribution.

We can adjust this later and this does not have to block this PR.

bast commented 4 years ago

And since you nicely listed the dev/test dependencies in pyproject.toml, I agree that in this case we probably don't need requirements.txt at all then. Possibly only containing flit to bootstap a venv.

robertodr commented 4 years ago

Let's fix the deploy in another step. I'll clean requirements.txt. Note that flit install --symlink will install all of dev, test, and doc dependencies.

bast commented 4 years ago

Let's fix the deploy in another step. I'll clean requirements.txt. Note that flit install --symlink will install all of dev, test, and doc dependencies.

yeah this is much nicer than lazy me who threw this into requirements.txt

bast commented 4 years ago

Deploy step followed up in #94.