search

dev-chat / mocker

Slack App to Automate Mocking Your Friends
0 stars 0 forks source link

Failed Deletions Should Be Queued #5

Closed sfreeman422 closed 5 years ago

sfreeman422 commented 5 years ago

Describe the bug If a user is muzzled, and is spamming the chat, they can get their messages through once the rate limit has been hit from Slack's API. Instead, we should add some retry logic that queues failed deletions, to at least clean up the chat after a user has spammed heavily. This is a band aid solution to Slacks API limits.

To Reproduce Steps to reproduce the behavior:

  1. Be muzzled
  2. Spam a short message, like one letter, frequently.
  3. Wait for the rate limit to be hit.
  4. See your messages going through and muzzle being thwarted.

Expected behavior Muzzled users should have all of their messages removed if they are spamming for the duration of their muzzle.

sfreeman422 commented 5 years ago

This one should be resolved on #12 however, I am going to leave this one open for the next week or so to be 100% sure. It seems that either Slack has upped their own retry logic and this may not be necessary as I was finding my rapid fire messages to be blocked from even sending in the first place shortly after the rate limit was hit. When the rate limit was hit, I also saw that Slack was using some retry logic on the delete within 1 second of the failed attempt.

sfreeman422 commented 5 years ago

Closing this as the above solution appears to resolve the issue.