search

dev-chat / mocker

Slack App to Automate Mocking Your Friends
0 stars 0 forks source link

@channel Gets through muzzle #8

Closed arrozconfrijoles closed 5 years ago

arrozconfrijoles commented 5 years ago

Describe the bug User can @channel while muzzled and it will occasionally be sent through muzzled and notify the entire group.

To Reproduce reproduce error by muzzling Koz. Otherwise you probably could self-muzzle yourself and repeatedly spam @channel until one gets through

Expected behavior @channel has to be a word that is completely eliminated by the muzzle. @here should also be eliminated

Screenshots image

sfreeman422 commented 5 years ago

This is successfully blocked .. sort of. The @channel will still get through given the fact that the app has to have a message successfully sent to the chat in order to then delete the original message and replace it with a muzzled message. The muzzled message however, will be properly muzzled. It is still unconfirmed whether or not everyone will get a notification on their phone when this happens. @arrozconfrijoles was seeing notifications however, it seems others may have not.. TBD.

sfreeman422 commented 5 years ago

Closing this issue. Since we cannot intercept messages before they hit Slack, we cannot reliably prevent @channel, @here and @user tags from causing a notification. We are choosing to instead punish offenders by increasing their muzzle by 5 minutes each time they tag any of the @'s mentioned above on PR #18