dev-est / tuya_tray

Tray application for Smartlife/Tuya
43 stars 9 forks source link

thoughts #5

Closed chiments closed 4 years ago

chiments commented 4 years ago

I was trying to send this a few days ago. ITs ugly.. but it works.

I posted to my fork.

mattanorak commented 4 years ago

@chiments - Need to add to the readme to do a: pip install PySimpleGUI to get the component installed and prevent an error on run.

mattanorak commented 4 years ago

Also, if you don't want to control all devices at once, there's no way to bypass this. Exiting it exits the whole routine and closes the app with no way to get back to controlling individual items. Remember, there are switches and bulbs in the original routine now.

dev-est commented 4 years ago

@chiments Looks interesting, can't seem to get it to run in the tray only seems to work as the application after hitting the exit. Might be interesting to move away from using HSV values and using a direct colour wheel that PyQt5 does already by importing QColorDialog in the widgets subpackage and calling QColorDialog.getColor()

chiments commented 4 years ago

@chiments - Need to add to the readme to do a: pip install PySimpleGUI to get the component installed and prevent an error on run.

I did - was "Requires: PySimpleGUI" not good enough for you?

mattanorak commented 4 years ago

Evidently not, as I missed it after reading the read me.

chiments commented 4 years ago

Also, if you don't want to control all devices at once, there's no way to bypass this. Exiting it exits the whole routine and closes the app with no way to get back to controlling individual items. Remember, there are switches and bulbs in the original routine now.

Again - not trying to be rude here.. but I noted this wasn't complete. I built functions that could be moved around or duplicated to get the desired result by manipulating the code. I figured it out by looking at the code, I would expect others to as well if needed. Sorry I didn't make it easy for you.

Exiting the GUI launches the sys tray app - individual control is present there.

dev-est commented 4 years ago

@chiments - Need to add to the readme to do a: pip install PySimpleGUI to get the component installed and prevent an error on run.

I did - was "Requires: PySimpleGUI" not good enough for you?

You need to remember that people possibly using the application won't be familar with using bash or Python in anyway, add the package to the requirements so they can just install using the default way.

mattanorak commented 4 years ago

Exiting the GUI launches the sys tray app - individual control is present there.

Hmm, it didn’t exit to the tray for me (using a Mac).

chiments commented 4 years ago

@chiments - Need to add to the readme to do a: pip install PySimpleGUI to get the component installed and prevent an error on run.

I did - was "Requires: PySimpleGUI" not good enough for you?

You need to remember that people possibly using the application won't be familar with using bash or Python in anyway, add the package to the requirements so they can just install using the default way.

Please excuse me that the way I uploaded my changes was not up to your standards. This isn't a completed product so I didn't think I needed to deliver one either. I spent a few hours on this NOT KNOWING PYTHON at all and I put this together to give control beyond what was posted to help out as a proof of concept to show what could be done, to then let the pros take over and keep going. I don't need to remember anything - maybe you need to remember not everyone is a developer. And try to help out rather than critique the readme. Good luck with this and thanks for sharing.

dev-est commented 4 years ago

@chiments - Need to add to the readme to do a: pip install PySimpleGUI to get the component installed and prevent an error on run.

I did - was "Requires: PySimpleGUI" not good enough for you?

You need to remember that people possibly using the application won't be familar with using bash or Python in anyway, add the package to the requirements so they can just install using the default way.

Please excuse me that the way I uploaded my changes was not up to your standards. This isn't a completed product so I didn't think I needed to deliver one either. I spent a few hours on this NOT KNOWING PYTHON at all and I put this together to give control beyond what was posted to help out as a proof of concept to show what could be done, to then let the pros take over and keep going. I don't need to remember anything - maybe you need to remember not everyone is a developer. And try to help out rather than critique the readme. Good luck with this and thanks for sharing.

I'm sorry that you feel offended in anyway, but we're just trying to help. We have no scope as to what kind of experience you have with Python. You're being extremely passive aggressive in regards to any form of criticism or points that we're raising that would allow other people to use your code it by adding a line on the readme file, considering you have spent hours on it.

I wish you the very best of luck in the future, and hope that you continue to create more applications.

chiments commented 4 years ago

@chiments - Need to add to the readme to do a: pip install PySimpleGUI to get the component installed and prevent an error on run.

I did - was "Requires: PySimpleGUI" not good enough for you?

You need to remember that people possibly using the application won't be familar with using bash or Python in anyway, add the package to the requirements so they can just install using the default way.

Please excuse me that the way I uploaded my changes was not up to your standards. This isn't a completed product so I didn't think I needed to deliver one either. I spent a few hours on this NOT KNOWING PYTHON at all and I put this together to give control beyond what was posted to help out as a proof of concept to show what could be done, to then let the pros take over and keep going. I don't need to remember anything - maybe you need to remember not everyone is a developer. And try to help out rather than critique the readme. Good luck with this and thanks for sharing.

I'm sorry that you feel offended in anyway, but we're just trying to help. We have no scope as to what kind of experience you have with Python. You're being extremely passive aggressive in regards to any form of criticism or points that we're raising that would allow other people to use your code it by adding a line on the readme file, considering you have spent hours on it.

I wish you the very best of luck in the future, and hope that you continue to create more applications.

Not offended - but I did add that Simplegui was a req. I can't cater to everyone and again I noted that it wasn't complete and had issues. The post was mainly meant for you. I tried to reach out via reddit becuase i was happy to see how you put this together. You guys jumped on me over the readme and not the code. The ColorWheel is a good thought, I saw that.. but you gotta start somewhere which is what i tried to do vs. requesting a feature. Thanks for the thumbs down - I surely could have done that too, but i didn't!! lol :)