search

dev-labs-bg / swift-video-generator

MIT License
639 stars 121 forks source link

I hope to add one more parameter to set video size, now in multi-picture mode. Size is fixed proportion. #62

Open cs571393 opened 4 years ago

tgeorgieva commented 4 years ago

@cs571393 Can you label your issue appropriately or add proper description if it's a bug you need help with?

cs571393 commented 4 years ago

@tgeorgieva Now in VideoGeneratorType. Multiple types, the setup method will default to 800 * 800 the image format, associated with videoImageWidthForMultipleVideoGeneration, now only a fixed ratio of 1:1. I want to add a parameter that sets the size of video. So let's say 1920 times 1080. Set it like this.

tgeorgieva commented 4 years ago

@cs571393 OK, feel free to fork the project and implement your changes. I don't know why you aded an issue, but I'll mark it as improvement. If you feel like creating a pull request after you've finished and tested the feature, I'll look it over and consider adopting it into the project.

cs571393 commented 4 years ago

@tgeorgieva If yes, can I set the project to 9.0? Now I can only import files into the project, but I cannot import them through cocoapod. Because my project is the lowest version that supports iOS9.0

tgeorgieva commented 4 years ago

@cs571393 You can do as you wish in your own project but I won't accept a merge request with a lower version. I'm not sure if some of the methods I use are even supported by lower versions of iOS anyway. Again, though, you can try to lower it in your own forked project and see if it works for you.

cs571393 commented 4 years ago

@tgeorgieva Can you add a cancel method?

tgeorgieva commented 4 years ago

@cs571393 What cancel method? Is this a bug you have? Or an improvement you need? I really don't understand why this issue was opened.

cs571393 commented 4 years ago

@tgeorgieva I happen to have a function in my app that composes video, and a function that cancels compositing, so I hope to have a function that can be cancelled.