search

dev-launchers / dev-launchers-platform

Monorepo for all DevLaunchers internal products and libraries used by the official platform
https://devlaunchers.org
GNU General Public License v3.0
38 stars 30 forks source link

[BUG] Dropdown Styles Broken in Idea Submission Form #1623

Open JulieMass opened 5 months ago

JulieMass commented 5 months ago

Steps to replicate are

  1. Go to IdeaSpace > Submit and idea https://devlaunchers.org/ideaspace/submit
  2. Scroll down the form and check the dropdown select under the label “What level of involvement do you want to have after submission?”

Device and OS

Expected behavior

Dropdown styles should adhere to both our global style guide and IdeaSpace’s UX design mockups.

image.png

Actual behavior

Dropdown styles deviate from our design system guidelines. For instance, the background is white instead of black.

image.png
JulieMass commented 5 months ago

Please add your planning poker estimate with Zenhub @JulieMass

dbradham commented 3 months ago

QA TESTING: The styling issue looks to be fixed, but the dropdown does not close when I make a selection, and my selection is not displayed when I click outside the dropdown to close it.

@Rutuja177 can you look into this whenever you are able? Thanks!

image.png image.png

CC: @JulieMass

dbradham commented 2 months ago

@Rutuja177 I'm not able to submit an idea because of the involveLevel value being posted to the backend here:

image.png image.png
Rutuja177 commented 2 months ago

Hey @dbradham,

image.png

Regarding the first issue, the Dropdown component sourced from the Style guide doesn't automatically close after a selection or update the title with the chosen option.

We need to update the existing dropdown component to include this functionality.

Let me know your thoughts on this.

@JulieMass

dbradham commented 3 weeks ago
image.png

I was able to find the receiveValue callback within the Dropdown component is the problem with the initial value not being set.

image.png
dbradham commented 3 weeks ago

https://github.com/dev-launchers/dev-launchers-platform/pull/1812

dbradham commented 3 weeks ago
image.png
dbradham commented 2 weeks ago

@JulieMass @chadcrotchett this has passed my QA testing. I have a pull request to get this bug fix, for the dropdown values not being set on the initial click, deployed to production-https://github.com/dev-launchers/dev-launchers-platform/pull/1828

JulieMass commented 2 weeks ago

@JulieMass @chadcrotchett this has passed my QA testing. I have a pull request to get this bug fix, for the dropdown values not being set on the initial click, deployed to production-#1828

(CC. @chadcrotchett )

Hi @dbradham and @Rutuja177 ,

I noticed an issue with the radio buttons inside the dropdown menu. They appear compressed and I'm also unable to select the third option: "I want to 'own' this idea to help with workshopping and designing until it becomes a project."

Could you both please take a look at this?

image

Enjoy2Live commented 2 weeks ago

@dbradham @JulieMass This is probably the first time I'm seeing this issue, if there's anything that is blocking you guys regarding implementation of shared components feel free to @me here on gh issues.

The dropdown in use (currently in prod) is considered deprecated thus it doesn't adhere to our global style guide and any changes on the figma components won't be reflected on the one being used by ideaspace's team so I suggest switching to the new maintained drowdown component found in here.

also I really like the suggestion of @Rutuja177 regarding closing the dropdown after selection, can you please create an issue with label "Platform Enablement" describing current behavior and expected one?

zar92 commented 2 weeks ago

Please confirm whether this problem is solved now. @dbradham @JulieMass CC: @chungthuang