Closed JulieMass closed 3 months ago
hi Julie, Kris and I talk about this, and we have some plan. I want to take this one.
Hi @alicefate (CC: @pyxld-kris) thanks! sure thing you can take it but unfortunately this is a user story that doesn't have designs yet so we are missing lots of definitions and it is a big one that might need the point of view of UX.
What have you discussed with Kris? what would be the approach decided? my first thought on how to approach it and to not make design a bottleneck is that (if @Nouri-Anouar is OK) we could do a small ideation session (you and Anwar or me) and sketch an initial design until Anwar can bring the final mockups. Let me know if this is aligned with what you discussed with Kris please.
We just try to find out what it need for frontend. Like, it will need authorization and new page. Having that I can make a ugly but functional page. I'm still trying to figure out other things what it might need.
Sure. It is.
Hi @alicefate sounds good 👍! The User story is assigned to you now and included in our sprint 😀.
Please can you include Anwar (@Nouri-Anouar our UX designer) in the conversation when deciding on definitions for this new page so in that way we make sure that we are building good FE foundations that have also the user experience point of view in account?
Thank you!
Hi @Nouri-Anouar, do you have any ideas for the dashboard. I'm still try to figure out dashboards functions. For the basic function which is filter their own idea, I thought we could add a button on browse page. When user click it, the page will only show their own ideas.
Hi @pyxld-kris, I got some questions and thoughts for the owner dashboard.
All users have to login to submit ideas and comments. What does the "author" information look like in props? They use userId / userName, or they have author like comments? And does the submission form include the author informaiton?
What does owner dashboard do besides show their own ideas. So for the basic function, filter their ideas can be done in two ways.
Either way, we can build a button on browse idea page and filter out owner idea and show them.
Besides, we don't have author information now.
I made a prototype about what I mean.
Hi @alicefate. Can I jump in and add my two cents here? First of all, great questions and thoughts Iris! All very good points.
Here goes my two cents for some of your questions:
Now, after reading your questions Iris you made me realize something: maybe all these items (list of ideas + comments on ideas I own + badges) should be under the user’s profile or account instead of a separate owner’s dashboard page? The reason we decided to build a separate dashboard initially was because the user profile is a completely different project (not IdeaSpace project). In fact we have an "ideas" tab in the current user profile.
The gamification idea is coming from an ideation session we made months ago with Haniya, Anna and Vini (initial team members of IdeaSpace):
Because my guess is that people like Miles will go look to their user account page to look for this dashboard information. It makes more sense since most of the apps do it this way. What do you think about this @pyxld-kris : should we build an “owner dashboard page” or should all these ideas be included in the DL user’s account page? and if so, can we do this?
@alicefate
Great questions! I'll tackle them in order:
What does the "author" information look like in props? They use userId / userName, or they have author like comments? And does the submission form include the author informaiton?
I did a little digging and it looks like that field represents a User Object in our backend, meaning that if the relationship is attached it comes with a lot of data. There's some work that needs to be done on the backend to connect these Users to Ideas when an idea is created, but I believe the plan there is to retroactively establish those relationships based on matching email
fields on Ideas and Users. Here's an image so you can see the extra data coming in from our backend! I can attach Users to Ideas manually if it's something you need for the dashboard.
What does owner dashboard do besides show their own ideas.
In my opinion, I think a really important thing that people will want to do is to edit or add to their Ideas. These ideas are meant to be workshopped and changed based on feedback, so we need some way for that process to happen in an organized way. Idea owners editing the core idea based on feedback is the simplest version of that particular process that I can think of right now, but it could be a good thing to bring up with the team. Down the line, version history might be an issue if we allow for editing, but that's a problem to be solved later.
So for the basic function, filter their ideas can be done in two ways.
- use api to search. (url = {keyword};)
- use if condition to filter out which idea's author-id equals to user-id I perfer the first one. People will need search function in the future.
I think eventually option (1) could be a great addition, but in my eyes that particular implementation would be solving a slightly different problem then we're setting out to solve with this User Story. When we add that type of search, it's really more about other people finding your ideas, whereas with this User Story we're focused on Miles Hardin being able to find his own ideas. With that being said, I think (2), filtering based on the authenticated user-id, meets the criteria perfectly.
In conclusion, your prototype looks great!
@JulieMass and @alicefate
re: User Profile (https://github.com/dev-launchers/dev-launchers-platform/issues/705#issuecomment-1307200867)
Eventually, we want to have things like this available in one location attached to the User Profile. However, right now may not be the right time for that. As an organization, we still have to come to a consensus on how we want to handle ownership of "shared space" like the User Profile, the Home Page, etc. Another problem is that, as you mentioned, the user profile exists in a separate app and it might add a bit of confusion into the mix if there's a bunch of extra User Profile noise around as Iris is coding.
Part of me thinks it's for the best that we standardize having all of our product teams build both a fully featured user dashboard for each individual project, and a separately maintained user profile widget. The pros to such a standard are that each product will be more likely to be able to run in a self-contained state (which is huge in the event that we want to release it as a standalone product in the future), and that it gives more control over the totality of the User Experience to the team creating the product. The big con that I see is that it's more work to develop and maintain both a dashboard and a widget. But, I'm not sure exactly how much more work that is. It also could introduce some user confusion around profiles, dashboards, admin consoles, settings, etc if we have a bunch of these going on down the line.
I'd love to hear thoughts there from anyone who has them! It will probably be something tackled between Team Leads in the nearish future once the monorepo transition is fully cemented, but we have a need now, which brings me to...
Due to the fact that the User Profile issues is unresolved, I think we should throw it out as a blocker and move forward with a dashboard contained in the IdeaSpace app! In the future, we can easily migrate it to the User Profile if desired when some of those issues have been resolved.
Hi @pyxld-kris ,
Thank you! Yes, I imagined the “user profile” being a different project, it wouldn’t be the best approach for the moment to try to include the dashboard there (still I had to ask just to make sure).
I also agree that doing this could bring confusion to our end users but as long as we make sure that the experience feels like an integrated one from their side it shouldn’t be a problem. After all, for the end user many of the DL projects are part of the same product, they don’t know we have different teams working on different areas. We just need to make sure that they can find what they are looking for in the place they expect it to be found and that they don’t have to learn how to use a different user profile every time they use a different project. The experience should feel consistent across all projects and this could be resolved with a consistent front-end. I’ll bring this up to our next meeting with the team leads and see what they think.
Finally, a last question: even though we are going to develop our own Idea’s dashboard, is it possible we include the access for Miles through the menu dropdown (an example of what I am picturing below)? Is this something our team can do?
@alicefate @Nouri-Anouar Description and acceptance criteria updated 🙌. Feel free to edit or add anything that I might have missed.
@pyxld-kris We discussed and defined together with Iris and Anwar what this user story could include and what it wouldn't (information is updated in the description).
Iris also mentioned she might need help from you getting the following information:
We also have a couple of questions we think are important to discuss in Friday's meeting with the rest of the team. These questions are:
@JulieMass I love the idea of linking to the dashboard from the dropdown!
From the second message:
idea's owner information coming from the form. So if Miles selects he wants to be the idea owner or he selects "no" either way Iris mentioned she needs a way to bring this information to the idea's dashboard somehow.
This is in the works. There is some backend work to be done here to finish that particular feature, and then that data will be available in all idea-card responses.
idea owner's email because once the new visual design is implemented this information should come from the user's profile (not the form).
In my most recent comment (before this one), I left an image that show's an idecard with full author info. In that, email is included. (Though I'm not sure if we want to include email in the long run)
Responses to your questions
What would happen if Miles creates an idea but decides he doesn’t want to be the idea leader? Should this idea still appear in his idea’s list in his dashboard? Also, how would people apply to be the idea leader?
I think it should, but maybe allow him to transfer it to someone? We'll need a way for ideas to be updated based on comment feedback, and having a central owner makes the most sense to me in the beginning.
Should we include a question on the form allowing people to consent if they want to share their email publicly or not?
I think either yes, or we have a discussion about not including emails at all.
@JulieMass @pyxld-kris About "accesses the idea's dashboard though category", should I leave it to the person who working on #658?
@Nouri-Anouar Also I need a slogan on login page. Do you have any suggestions?
@alicefate Here are some examples that need improvement:
@JulieMass @pyxld-kris, what are your thoughts?
Hi @alicefate and @Nouri-Anouar ,
Replying to your questions below:
Iris question: About "accesses the idea's dashboard though category", should I leave it to the person who working on #658? ---> Julie: Thanks for the heads up with this Iris! I forgot to update this user story’s description and success criteria after our meeting on Friday. Kris mentioned it is possible for us to include the link under the user profile’s menu (once Miles is signed in or registered) so I’ve just updated the description on this user story to match our decision from last Friday. Also my suggestion would be that we build this under this user story because #658 only involves the top nav menu navigation (not the user profile navigation). Would this be OK for you Iris? Do you think we can build this in this sprint or do you prefer us creating a new user story for future sprints? Let me know please and I’ll create a task for next sprints if needed.
We would also need to define the label for this dashboard under the user profile. Anwar, what do you think? Which label should we use for the dashboard? Leaving below two suggestions:
Finally, great slogans Anwar! My positive vote goes for the first one: “Everything about your ideas in one place” 🥰
Does it mean I should build a profile’s menu just like github do and it will replace the current orange menu button? If it so, I think it should be a new user story.
I also like the first one slogan!
Hi @alicefate, the user profile's menu is currently developed so I was more thinking of adding the link to the idea's dashboard but yes, let's leave this task then for the next sprint 👍.
I'll remove the point of including the link from the user profile in this user story description and success criteria so it is updated 🙌.
@Nouri-Anouar re: tagline
I agree with @JulieMass, your first one is great!
@Nouri-Anouar I have questions for submit button. Should it be always on a new line or it can follow other ideas cards? If it is the second situation, can I have an example. For now, submit button is the same size as other picture.
Kris may want the idea's slogan. He metioned once.
@dbradham Is there a way for me to see this from production? or is it only visible in dev environment?
:tada: This issue has been resolved in version 2.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
@dbradham Was this ticket closed automatically by Zenhub? I can’t access the dashboard from production so I reopened it.
Any idea why the dropdown from the top nav disappeared?
Also, what would be the best way to handle fixing the access to the dashboard in this ticket? Should we create a bug to give fix the dashboard access or should we keep this ticket open to resolve it?
@JulieMass I would recommend that we create a new ticket for navigation to the dashboard page. It appears the navigation to the page was not considered in the redesign of the top nav bar. (it seems users used to be able to access this from the MENU button in the nav bar? or did they access the dashboard with a different link? I'm still not clear how they USED to get there.)
The confusion here seems to stem from your and Iris' interaction on 11/15... she recommended moving the navigation to its own story, and your response is that we could remove this requirement. It looks like the requirement was never removed from the acceptance criteria here, and Iris submitted her changes without it.
Can you post the current design for the top nav? It looks like this ticket and another are based on old designs. Also, what was the old UX for access the dashboard? Was it only though the "MENU" button? That was deleted by platform enablement.
Per the designs here (https://github.com/dev-launchers/dev-launchers-platform/issues/658) there is no MENU button on the top nav.
I don't see this dropdown for accessing the dashboard anywhere here: https://www.figma.com/file/hEDIHsBZYa6hmK8As5mcjy/%5BDL---IdeaSpace%5D-UX-designs?node-id=0%3A1&t=atvTxCjnYtr5FVE3-0
Kris mentioned it is possible for us to include the link under the user profile’s menu (once Miles
Thank you Dave. Yes, I'm trying to figure out what happened with the top nav because it is very confusing. We are missing both top nav dropdowns right now: the IdeaSpace drop down and the user profile drop down 🫠.
In respect to this ticket, yes, you were right that in the comment history I mentioned to Iris that I was going to delete the point related to accessing the dashboard from the user profile dropdown and I must have forgotten 🤦♀️. Thank you for that! I'll delete this point in the AC now:
Though unfortunately we cannot approve and close this user story because how do I check that this story follows the AC if I cannot access the page? 😔 If there is a way to check this please let me know, otherwise we'll have to wait for the dropdown to reappear again in the top nav.
@JulieMass This is not working as expected because when we query the backend for ideas, the author for the idea is not present. This is different than the issue with the idea form submission, because I have manually set the author for a couple of idea cards, but cannot access the author data in the frontend for the time being.
Iris implemented this feature such that all of the ideas were requested, and then a filter was applied on the frontend to remove ideas which were not created by the current user. The logic looks good, but this missing data in the response from the backend is blocking us from closing this ticket.
What is strange here is that the comments are pulling in as expected. So the relational fields don't seem to be the issue. It looks like there is something specific to the author/user.
There are some bugs here from Strapi migration. I'm going to make a PR to resolve @JulieMass
@JulieMass other thing I noticed here is the "workshop this idea" button takes the user to the "edit" page. Please confirm this should send a user to the workshopping page instead.
@JulieMass other thing I noticed here is the "workshop this idea" button takes the user to the "edit" page. Please confirm this should send a user to the workshopping page instead.
Hey @dbradham, thanks for the PR to fix those issues from Strapi.
About that "workshop this idea" question: I can see how that label is a bit confusing. But I checked the designs, and yeah, that does seem to be the right label for the ideas that you own as the idea owner. The ideas under "ideas I follow" though should have a different button that says "Help this idea" instead.
Also, just to let you know, I can't seem to submit ideas in staging right now 😔. When I try, I'm getting this error (screenshot attached), so I'm going to have to move this ticket back to QA so we can look into that.
After discussion with @dbradham, assigning this item to @SAI-BHASKAR-PENNADA. Sai, Dave will schedule a call with you to give you some background on what is needed here.
(CC. @chadcrotchett) Hi @dbradham ,
I have a couple of questions regarding this ticket:
Dashboard subtitle: The dashboard subtitle currently doesn't align with our designs. Can we address this within the scope of this ticket, or would it require significant effort? If significant effort is needed, we can create a separate bug ticket. Please advise on the best approach.
“My ideas” card button labels: I agree with you that the button label on the cards isn't ideal. I've reviewed the designs, and it appears incorrect. To get everyone's input on how to proceed, I'll be posting this question in our Discord channel, including the designers and the researcher.
Please let me know your thoughts on question 1.
Thanks!
@JulieMass I would make a new ticket. I believe a lot of these styles broke on different pages within the app at the same time. (I believe there was a styles migration)
Ideally we could address all pages where the styling is similarly broken in the same ticket.
@JulieMass I would make a new ticket. I believe a lot of these styles broke on different pages within the app at the same time. (I believe there was a styles migration)
Ideally we could address all pages where the styling is similarly broken in the same ticket.
OK, thanks Dave!
As discussed in our Discord channel, I’ve assigned the ticket to you and moved it to "Work in Progress" so we can change the button labels to “Edit This Idea”.
I noticed the description wasn't as clear as it could be (being one of our first tickets). I've updated the description, acceptance criteria, and even added some images to make things easier to understand. Let me know the ticket description looks OK for you and feel free to add or change whatever is needed in case I missed anything.
I’ve also created a separate ticket for the bug of the subtitle broken styles: https://app.zenhub.com/workspaces/ideaspace-team-6350185d9843157427cc900b/issues/gh/dev-launchers/dev-launchers-platform/1834
Thanks again,
Seeing expected results in QA here. This is ready for release at the end of the current sprint. @JulieMass @chadcrotchett
Considerations: As an idea owner Miles Hardin wants to access his idea’s dashboard page to be able to follow his ideas and the latest comments from people that are workshopping on them with him.
This user story includes:
This user story DOESN'T include the following features which will be included in future sprints:
Acceptance criteria:
Sub-tasks:
In scope for this ticket: