search

dev-launchers / dev-launchers-platform

Monorepo for all DevLaunchers internal products and libraries used by the official platform
https://devlaunchers.org
GNU General Public License v3.0
41 stars 30 forks source link

#742: Show Idea Creator info on Idea page #742

Open JulieMass opened 2 years ago

JulieMass commented 2 years ago

Considerations: We’ll update the content and the visual design of the idea creator board in the workshopping page.

Acceptance criteria:

Sub-tasks:

image.png

liwenlin664477 commented 1 year ago

Hi Julie @JulieMass, I think that is good for me and I just want to know what kind of block it is. Thanks!

JulieMass commented 1 year ago

Hi Julie @JulieMass, I think that is good for me and I just want to know what kind of block it is. Thanks!

Hi @liwenlin664477 awesome 😀! thank you so much for taking this task Will! It is all yours 💪, just be aware that we had a design task dependency for @Nouri-Anouar here because our designs for the board aren't updated yet. So I would suggest that you both work together defining the missing parts and "UX/dev pair" for this task like we did before with Iris.

What is pending to define is the following:

The rest are things that need to be removed from the designs like the email, etc. (please check the picture I added above in the description of the user story)

You both can talk and define this in our next weekly on Sunday with the rest of the team too. It would be perfect because you can have other points of view too and it would be more efficient. What do you think?

JulieMass commented 1 year ago

Oh also, I forgot: please @liwenlin664477 can you estimate the task?

liwenlin664477 commented 1 year ago

@JulieMass Yes Julie, I just estimated it.

Nouri-Anouar commented 1 year ago

Hi Julie @JulieMass, I think that is good for me and I just want to know what kind of block it is. Thanks!

Hi @liwenlin664477 awesome 😀! thank you so much for taking this task Will! It is all yours 💪, just be aware that we had a design task dependency for @Nouri-Anouar here because our designs for the board aren't updated yet. So I would suggest that you both work together defining the missing parts and "UX/dev pair" for this task like we did before with Iris.

What is pending to define is the following:

  • how are we going to call Miles (the person who submits an idea)? should we call them "idea owner", "idea creator", another name? and based on what it is defined we would have to update the designs on this board.

The rest are things that need to be removed from the designs like the email, etc. (please check the picture I added above in the description of the user story)

You both can talk and define this in our next weekly on Sunday with the rest of the team too. It would be perfect because you can have other points of view too and it would be more efficient. What do you think?

Thank is a great idea @JulieMass, I would love to work with you and @liwenlin664477 on this. I just updated the product owner card design. looking forward to discuss this with you all today.

Nouri-Anouar commented 1 year ago

image

JulieMass commented 1 year ago

Hey @liwenlin664477 I noticed this item was moved to "Review/QA" column 16 days ago. I'm a little lost here: Is this task completed? have you sent a pull request for Dave to review? because my understanding was that you both were going to meet so Dave could continue this task were you left off.

(CC. @dbradham )

liwenlin664477 commented 1 year ago

Yes, I remember I have already pushed my code. Let me double-check about it. If not, I will push it again. Sorry for the misunderstanding @JulieMass .

liwenlin664477 commented 1 year ago

Yes, @JulieMass. For this issue, the code is in the Will-Li/Workshopping-page-save-button-and-creator-information branch.

JulieMass commented 1 year ago

Yes, @JulieMass. For this issue, the code is in the Will-Li/Workshopping-page-save-button-and-creator-information branch.

Hi @liwenlin664477 thank you soooo much 🙌 🙏! Dave also mentioned you both went through this together already as well.

dbradham commented 8 months ago

Confirmed this is working as expected @JulieMass can this ticket be closed?

image.png
dbradham commented 5 months ago

@chadcrotchett @JulieMass I am moving this to done because it passes all of my QA tests. However, the profile picture shown here is essentially a random photo. I'm not sure if we have the ability within user profile to set the profile picture, so I don't have a way to implement or test that.

JulieMass commented 5 months ago

Hi @dbradham ,

I'm currently reviewing this ticket in colum "done" but I've identified a couple of issues that prevent us from closing it:

- Mismatch between Acceptance Criteria and Staging Environment: There's a discrepancy between what's described in the acceptance criteria and what's currently implemented in the staging environment (screenshot below).

- Exposed PII in Global Staging: The global staging environment appears to contain what might be personally identifiable information (PII). Sharing emails publicly is a major concern.

Given these findings, I'm moving this ticket back to the product backlog. We'll need to reassign it to a developer to address the mismatch and ensure PII is removed from the staging environment.

@chadcrotchett and @dbradham , please let me know if you have any suggestions or alternative approaches we should consider.

image.png