search

dev-launchers / dev-launchers-platform

Monorepo for all DevLaunchers internal products and libraries used by the official platform
https://devlaunchers.org
GNU General Public License v3.0
41 stars 30 forks source link

[US] As MILES HARDIN, I want to like a comment so that I can show my support for it #748

Open JulieMass opened 2 years ago

JulieMass commented 2 years ago

Considerations: Ability to like comments on the workshopping page's comment feed.

Please refer to UX designs for IdeaSpace's workshopping page in Figma

For the interaction of how a like button should function, please check out the DL styleguide in ORGANISM > Product cards. (screenshot below).

Acceptance criteria:

Sub-tasks:

image.png

Like button user interaction should follow our DL styleguide: image.png

JulieMass commented 1 year ago

Hi @RETprojects, thanks for assigning to yourself this task 😀! Please check the description above when you can because I updated the information related to how the like button should behave. The interaction of like buttons is in DL styleguide: basically if it isn't' clicked by thy user it should have an empty heart icon. And once clicked it should show a filled heart + the amount of people that liked that comment.

I hope this helps and let me know if you have questions please.

JulieMass commented 1 year ago

Hi @RETprojects today we were discussing some design topics with Anwar and Will today and I realized that I missed to add something here in this user story.

Would it be possible if we add a tooltip to our "like" button so we can show a tooltip when Miles does a mouse over on it?

image.png

I don't know how this should be done with React (I'll leave that to you as the expert hehe) but since I only know basic html, it would be kind of like adding a title attribute to the button like this: https://www.w3schools.com/html/tryit.asp?filename=tryhtml_attributes_title

What do you think? do you think we could include this in this user story or would it be too complex to do this? Let me know please your thoughts.

RETprojects commented 1 year ago

I think that a tooltip over the like button is doable in React. We could add this to the user story, although I haven't played around with tooltips yet.

On Wed, Dec 21, 2022 at 7:54 PM Julie @.***> wrote:

Hi @RETprojects https://github.com/RETprojects today we were discussing some design topics with Anwar and Will and I realized one thing that I missed to add in this user story related to adding a tooltip for the like button.

Would it be possible if we add a tooltip to our "like" button so we can show a tooltip when Miles does a mouse over on it?

[image: image.png] https://camo.githubusercontent.com/36a517ae21c03b3e43b20f465200060b4b9692059c5f4c0c812d2d721a2ef8b3/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3633343030663364316537393631346534356439656264392f64363531343038322d363563302d343633662d383234642d356365336632653166333232

I don't know how this should be done with React (I'll leave that to you as the expert hehe) but since I only know basic html, it would be kind of like adding a title attribute to the button like this: https://www.w3schools.com/html/tryit.asp?filename=tryhtml_attributes_title

What do you think? do you think we could include this in this user story or would it be too complex to do this? Let me know please your thoughts.

— Reply to this email directly, view it on GitHub https://github.com/dev-launchers/dev-launchers-platform/issues/748#issuecomment-1362295514, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASO74UCFMNXGDUY2KS5BE3TWOOYEJANCNFSM6AAAAAASKMPOQA . You are receiving this because you were mentioned.Message ID: @.***>

JulieMass commented 1 year ago

OK, thank you @RETprojects 👑 ! I won't include it in the acceptance criteria then, so we can leave it as a "nice to have" in case it gets too complex to develop.

JulieMass commented 1 year ago

Blocked due to dependencies with Platform enablement team. Back end needs to be worked on.

JulieMass commented 1 year ago

After today's sprint review, we have decided to move this ticket to the icebox so that Remi can continue working on it once he’s done with his current ticket.

JulieMass commented 1 year ago

Our OKR can be found in the following document: [DL - IdeaSpace] One Metric That Matters (OMTM) & OKRs

We'll be able to start tracking our OKR and OMTM once we have the following ticket developed #1195

JulieMass commented 8 months ago

Hey @RETprojects, just wanted to give you a heads up that I've updated this ticket description with the latest link to our new styleguide from the Universal Design team.

JulieMass commented 7 months ago

As discussed today with @RETprojects and @dbradham in Discord, we are moving this ticket to the icebox so Remi can focus on his current bug #953. We’ll come back to this one later. Thank you Remi!