search

dev-osrose / osIROSE-new

Open Source ROSE online server
http://forum.dev-osrose.com
Apache License 2.0
59 stars 30 forks source link

serverData/externalIP is used for two completely different reasons #225

Closed L3nn0x closed 4 years ago

L3nn0x commented 4 years ago

In the config file, serverData -> externalIP is used for two reasons inside our servers: the first one is to connect to the isc server and the second one is to tell the client to connect to that IP when switching maps. We should only have one usage for that.

We should use charServer -> loginIP and mapServer -> charIP to connect to the ISC server instead.

L3nn0x commented 4 years ago

Basically change https://github.com/dev-osrose/osIROSE-new/blob/f5f3002552c32bf3287b2bcd6ad94bc691fd0b02/src/map/src/cmapisc.cpp#L155 and https://github.com/dev-osrose/osIROSE-new/blob/f5f3002552c32bf3287b2bcd6ad94bc691fd0b02/src/char/src/ccharisc.cpp#L172

from 

RoseCommon::Isc::ServerType::MAP_MASTER, config.mapServer().channelName, config.serverData().externalIp,

to

RoseCommon::Isc::ServerType::MAP_MASTER, config.mapServer().channelName, config.mapServer().charIP,

And same thing for the char server