Open Audit Log on an soft-deleted record results in an Exception

dev-partners / laravel-nova-auditable-log

A Laravel Nova resource tool for visualizing the audit log created by the Laravel Auditing package.

51 stars 22 forks source link

Open Audit Log on an soft-deleted record results in an Exception #10

Closed ludgerey closed 4 years ago

ludgerey commented 4 years ago

Reproduce:

Create a Model with SoftDeletes enabled
Create a record in Nova
Delete the record in Nova
Set Filter to "With Trashed"
Open record in Nova again
Click on "Audit Log"

-> Nova will show an Exception:

Too few arguments to function Devpartners\AuditableLog\ToolServiceProvider::Devpartners\AuditableLog\{closure}(), 1 passed in [...]/Illuminate/Auth/Access/Gate.php on line 469 and exactly 2 expected

Sorry, I currently have no time to fix the issue by myself and create a PR.

recycledbeans commented 4 years ago

Hey @ludgerey thanks for reporting this. I'll see if I can create a PR today to resolve.

recycledbeans commented 4 years ago

Hey @ludgerey - I pushed a fix for this just now, which is available in v1.0.8 (make sure composer pulls in that latest version upon update).