search

dev-sec / ansible-collection-hardening

This Ansible collection provides battle tested hardening for Linux, SSH, nginx, MySQL
http://dev-sec.io/
Apache License 2.0
4.09k stars 732 forks source link

Updating version in galaxy.yml should be part of the release process #396

Closed Normo closed 3 years ago

Normo commented 3 years ago

Is your feature request related to a problem? Please describe. The version specified inside galaxy.yml should be equal to the latest available release. The current release is 7.1.1, but the specified version is 7.0.0 (2021-02-10). Related PR is #395.

Describe the solution you'd like Updating the version inside galaxy.yml should be part of the release process.

Additional context I noticed this issue when installing the collection from the git repository using the latest commit on the master branch. The requirements.yml I used:

collections:
  - name: https://github.com/dev-sec/ansible-collection-hardening.git
    type: git
    version: master

Installing the role:

$ ansible-galaxy collection install -r requirements.yml 
Starting galaxy collection install process
Process install dependency map
Starting collection install process
Installing 'devsec.hardening:7.0.0' to '.../collections/ansible_collections/devsec/hardening'
Created collection for devsec.hardening at .../collections/ansible_collections/devsec/hardening
devsec.hardening (7.0.0) was installed successfully
Installing 'community.crypto:1.4.0' to '.../collections/ansible_collections/community/crypto'
Downloading https://galaxy.ansible.com/download/community-crypto-1.4.0.tar.gz to ~/.ansible/tmp/ansible-local-7884z11xrbh8/tmpkl64wh0m
community.crypto (1.4.0) was installed successfully

(Actually I expected to get the latest commit f0350533812208930bba3aa4e7f2ecaca8900296 - I don't know if this a bug by ansible-galaxy or if I did something wrong.)

schurzi commented 3 years ago

fixed by #395