search

dev-sec / chef-windows-hardening

This chef cookbook provides windows hardening configurations for the DevSec Windows baseline profile.
http://dev-sec.io
96 stars 42 forks source link

Fix Empty Recipe & CIS EventLog Size Requirements #39

Closed bdwyertech closed 5 years ago

bdwyertech commented 5 years ago

Empty recipes can cause errors when provisioning with Packer & WinRM

    amazon-ebs: [2018-12-07T04:02:16+00:00] ERROR: Running exception handlers
    amazon-ebs: Running handlers complete
    amazon-ebs: [2018-12-07T04:02:16+00:00] ERROR: Exception handlers complete
    amazon-ebs: Chef Client failed. 0 resources updated in 04 seconds
    amazon-ebs: [2018-12-07T04:02:16+00:00] FATAL: Stacktrace dumped to c:/windows/temp/packer-chef-solo/local-mode-cache/cache/chef-stacktrace.out
    amazon-ebs: [2018-12-07T04:02:16+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
    amazon-ebs: [2018-12-07T04:02:16+00:00] FATAL: SyntaxError: c:/windows/temp/packer-chef-solo/local-mode-cache/cache/cookbooks/windows-hardening/recipes/user_rights.rb:1: invalid multibyte char (UTF-8)
bdwyertech commented 5 years ago

No love?

atomic111 commented 5 years ago

for sure, i work on it. because there is a mistake of No one, because it should be a empty array and not include the SID 1-0-0

atomic111 commented 5 years ago

i fixed it already the windows-baseline and now i have to fix this in the cookbook

atomic111 commented 5 years ago

if this is merged #42 , then please rebase your branch

atomic111 commented 5 years ago

@bdwyertech can you please rebase your branch. then i will merge it

bdwyertech commented 5 years ago

Sure, will do now @atomic111

bdwyertech commented 5 years ago

Should be good @atomic111

atomic111 commented 5 years ago

create thank you!!!