search

dev-sec / cis-docker-benchmark

CIS Docker Benchmark - InSpec Profile
https://dev-sec.io/baselines/docker/
Apache License 2.0
489 stars 114 forks source link

update inspec.yml #64

Closed MoisesTapia closed 4 years ago

MoisesTapia commented 4 years ago

the value default is deprecated and in the new versions of inspec we need change the value default for value

MoisesTapia commented 4 years ago

the value default is deprecated and in the new versions of inspec we need change the value default for value

chris-rock commented 4 years ago

@MoisesTapia Great improvement. Can you sign off the commits please?

MoisesTapia commented 4 years ago

@chris-rock I try to sing off but git return me an error: remote: Permission to dev-sec/cis-docker-benchmark.git denied to MoisesTapia. fatal: unable to access 'https://github.com/dev-sec/cis-docker-benchmark/': The requested URL returned error: 403

micheelengronne commented 4 years ago

Sign on your own repository. On https://github.com/MoisesTapia/cis-docker-benchmark

MoisesTapia commented 4 years ago

I am trying to sign it from my repository but I cannot what are the command to sign it?

micheelengronne commented 4 years ago

Click on Details on the DCO line in the Some checks were not successful.

MoisesTapia commented 4 years ago

Done

micheelengronne commented 4 years ago

It is still not green. Is your local git email the same as the one you set on Github ? It should be.

Edit: In fact, you successfully signed the last commit. You must sign all of them.

MoisesTapia commented 4 years ago

yes it's the same ...

This commit was signed with a verified signature.

commit

micheelengronne commented 4 years ago

Yes, I saw it. It is your previous commits you must also sign.

MoisesTapia commented 4 years ago

sorry but, how can I do it

micheelengronne commented 4 years ago

I think you should squash your commits into one and sign off this resulting commit.

Here is a tutorial on how to accomplish that https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

micheelengronne commented 4 years ago

I you are unsure of what you do, do a backup of your git repo as incorrectly rewriting a git history can lead to commit loss (data loss).