search

dev-sec / docker-ansible

Docker containers that include ansible latest stable 2.x version.
GNU General Public License v3.0
23 stars 14 forks source link

added yamllint and ansible-lint to installation #4

Closed rkno82 closed 5 years ago

rkno82 commented 6 years ago

Hi @rndmh3ro ,

would you accept that addition? I can add that to, I guess, to every Dockerfile if you are interested.

Thanks, Robert

rndmh3ro commented 6 years ago

Hey Robert,

does the size of the images increase dramatically after this?

rkno82 commented 6 years ago

Hey Robert,

does the size of the images increase dramatically after this?

Image Size
original 333 MB
new 366 MB
rndmh3ro commented 6 years ago

Works for me. Is it still WIP?

rkno82 commented 6 years ago

No. CentOS 7 is sufficient for me!

Von meinem iPhone gesendet

Am 18.10.2018 um 21:24 schrieb Sebastian Gumprich notifications@github.com:

Works for me. Is it still WIP?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

szEvEz commented 6 years ago

Hello,

if adding yamllint and ansible-lint, I'd recommend to add it to every Dockerfile.

If you only need it for CentOS 7 - I'd say creating an own Image and using "rndmh3ro/docker-centos7-ansible" as base image is the better way.

rkno82 commented 5 years ago

Hello,

if adding yamllint and ansible-lint, I'd recommend to add it to every Dockerfile.

If you only need it for CentOS 7 - I'd say creating an own Image and using "rndmh3ro/docker-centos7-ansible" as base image is the better way.

That's @rndmh3ro decission, not yours? I'm just politely asking whether he want's to accept that changes.

rndmh3ro commented 5 years ago

After thinking about this some more, I think "polluting" the image with other tools than Ansible is no the right approach, but instead @szEvEz's way is the best:

If you only need it for CentOS 7 - I'd say creating an own Image and using "rndmh3ro/docker-centos7-ansible" as base image is the better way.