dev-sec / nginx-baseline

DevSec Nginx Baseline - InSpec Profile
https://dev-sec.io/baselines/nginx/
Apache License 2.0
104 stars 45 forks source link

Declare control source as UTF-8 encoding. #34

Closed james-stocks closed 5 years ago

james-stocks commented 5 years ago

Fixes #33

There are a number of issues open and closed for encoding in InSpec profiles https://github.com/inspec/inspec/issues?utf8=%E2%9C%93&q=is%3Aissue+encoding

To work in all versions of InSpec currently supported, this profile should keep the # encoding: UTF-8 declaration.

Signed-off-by: James Stocks jstocks@chef.io

zenspider commented 5 years ago

This commit doesn't make sense to me. Someone want to give me some background? Ruby's default internal encoding has been UTF-8 since 2.0.

chris-rock commented 5 years ago

This is really a bug in InSpec that we mitigate here. Therefore you should better ask there.

zenspider commented 5 years ago

I'm on inspec, which is why I'm asking...