dev-sec / puppet-os-hardening

This puppet module provides numerous security-related configurations, providing all-round base protection.
http://dev-sec.io/
Apache License 2.0
280 stars 101 forks source link

Added manage_system_users option and formatted properties #262

Closed hp197 closed 3 years ago

hp197 commented 3 years ago

We have encountered issues where we have duplicate declaration in our environment. This is mainly with modules who manage their own system user/group (for example a mysql/postgres user). When both the other module and os-hardening define the user you get a duplicate declaration.

We do want to implement most parts of this module, but want to be able to exclude the managed (system) user account.

mcgege commented 3 years ago

@hp197 Thanks for this PR, looks good to me ... could you also please add an entry in README.md?

hp197 commented 3 years ago

Sure, will do

On Sat, Feb 6, 2021, 11:14 Michael Geiger notifications@github.com wrote:

@hp197 https://github.com/hp197 Thanks for this PR, looks good to me ... could you also please add an entry in README.md?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dev-sec/puppet-os-hardening/pull/262#issuecomment-774441387, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKRKZGPMKMV452LI4XE2KLS5UJBFANCNFSM4XBLOTIQ .

hp197 commented 3 years ago

squashed commit documentation into

mcgege commented 3 years ago

Perfect, can we merge this?

hp197 commented 3 years ago

go go go