dev-sec / puppet-os-hardening

This puppet module provides numerous security-related configurations, providing all-round base protection.

http://dev-sec.io/

Apache License 2.0

279 stars 101 forks source link

Add ignore_max_files_warnings (#279) #280

Closed earthgecko closed 3 years ago

earthgecko commented 3 years ago

Allow user to disable puppet warnings related to max_files exceeding default of 1000 if they choose to

codecov-commenter commented 3 years ago

Codecov Report

Merging #280 (03e797c) into master (47f336f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files           4        4           
  Lines          49       49           
=======================================
  Hits           20       20           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47f336f...03e797c. Read the comment docs.

earthgecko commented 3 years ago

I cannot say why the puppet5 tests are failing.

mcgege commented 3 years ago

@earthgecko Looks like this max_files option was not present in Puppet v5 ... but as this version is EOL since beginning of this year, I'll remove those tests now. When done I'll trigger you and then please merge that ...

mcgege commented 3 years ago

Tests changed, please merge latest changes into your branch and retry

earthgecko commented 3 years ago

@mcgege thanks, merged, hopefully that should do it.

mcgege commented 3 years ago

Looks good, many thanks for your PR!

earthgecko commented 3 years ago

@mcgege no thanks needed. Thank you for maintaining the module.