search

dev-sec / puppet-os-hardening

This puppet module provides numerous security-related configurations, providing all-round base protection.
http://dev-sec.io/
Apache License 2.0
279 stars 101 forks source link

fix CI: use docker driver for transfering files #290

Closed schurzi closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #290 (63972e5) into master (53e57d9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files           4        4           
  Lines          49       49           
=======================================
  Hits           20       20           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53e57d9...63972e5. Read the comment docs.

schurzi commented 2 years ago

so originally I thought that was because of a update of r10k (https://rubygems.org/gems/r10k/versions/3.13.0) that was done one day prior.

The main problem is, that kitchen wants to copy all files and in the r10k spec tests is a directory symlink with an invalid target. this breaks the copy.

schurzi commented 2 years ago

by using the docker driver we do not run into issues, because there is no copy process, that will hit the invalid symlink

mcgege commented 2 years ago

What? That was it? I also tried to disable the sftp transport (and hoped that this would reuse the right default), but then I gave up .. thanks a lot!!