search

dev-sec / puppet-os-hardening

This puppet module provides numerous security-related configurations, providing all-round base protection.
http://dev-sec.io/
Apache License 2.0
279 stars 101 forks source link

Bc satisfy lynis #294

Open brentclark opened 2 years ago

brentclark commented 2 years ago

Good day

I would like to submit a PR to disable some network protocols that typically are not used. This will too satisfy Lynis.

Regards Brent

codecov-commenter commented 2 years ago

Codecov Report

Merging #294 (5b247b6) into master (690b5c9) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5b247b6 differs from pull request most recent head 89dfe22. Consider uploading reports for the commit 89dfe22 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files           4        4           
  Lines          49       49           
=======================================
  Hits           20       20           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 690b5c9...89dfe22. Read the comment docs.

mcgege commented 2 years ago

@brentclark Thanks for your PR! In general this looks good to me, but you should also make it configurable like $disable_filesystems (in init.pp plus documentation in README.md)