search

dev-sec / ssh-baseline

DevSec SSH Baseline - InSpec Profile
https://dev-sec.io/baselines/ssh/
Apache License 2.0
283 stars 78 forks source link

max_auth_tries is a string not numeric #139

Closed chbiel closed 5 years ago

chbiel commented 5 years ago

Describe the bug Since PR https://github.com/dev-sec/ssh-baseline/commit/992faad17dd1589000d12e47e32fd584b2bb9343 we get the following error:

amazon-linux-ami:   ×  sshd-19: Server: Specify Limit for maximum authentication retries
amazon-linux-ami:      ×  SSHD Configuration MaxAuthTries should be == 2
amazon-linux-ami:      expected: == 2
amazon-linux-ami:           got:    "2"

Expected behavior Test should pass.

Actual behavior

amazon-linux-ami:   ×  sshd-19: Server: Specify Limit for maximum authentication retries
amazon-linux-ami:      ×  SSHD Configuration MaxAuthTries should be == 2
amazon-linux-ami:      expected: == 2
amazon-linux-ami:           got:    "2"

Inspec Version 3.6.6

chris-rock commented 5 years ago

@chbiel Great observation. Thank you. Can you open a PR to replace the be with InSpec's cmp matcher?

chbiel commented 5 years ago

Yeah, I create a PR today

chris-rock commented 5 years ago

That is awesome. Thank you 🙏

Sent from my iPhone

Sent from my iPhone

On 27. Aug 2019, at 08:13, Christopher notifications@github.com wrote:

Yeah, I create a PR today

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.