search

dev-sec / ssl-baseline

DevSec SSL/TLS Baseline - InSpec Profile
https://dev-sec.io/baselines/ssl/
Apache License 2.0
66 stars 23 forks source link

Supports os-family: unix required? #25

Open p0rkjello opened 5 years ago

p0rkjello commented 5 years ago

Describe the bug It appears that this profile would work on Windows. There does not appears to be any method of over writing the platform support on dependent profiles.

Expected behavior Supports unix and windows

Actual behavior

  [SKIP]  ssh-01: client: Check ssh_config owner, group and permissions.
     [SKIP]  Profile ssh-baseline is not supported on platform windows_10_pro_n/10.0.17134.
  [SKIP]  ssh-02: Client: Specify the AddressFamily to your need
     [SKIP]  Profile ssh-baseline is not supported on platform windows_10_pro_n/10.0.17134.

Example code

supports:
  - platform-family: unix
  - platform-family: windows
depends:
  - name: ssl-baseline
    url: https://github.com/dev-sec/ssh-baseline/archive/master.tar.gz

OS / Environment

Inspec Version

2.1.72

Baseline Version

1.3.0

Additional context Add platform support dependency for windows.

Kollibri commented 4 years ago

I can confirm that this works on Windows Server 2016 at least. I copied the ssl_test.rb to my local inspec tests and ran it and it worked as expected. Would be nice to be able to just point to the github though, but the os restriction prevents it workings for windows OS.