Closed mw10013 closed 11 months ago
I will look into this as soon as I get half an hour or so to deeply check the implementation, @mw10013! I'm not sure if it will be today or tomorrow, but I promise I will look into it!
Also, I will invite you to remix-auth-totp-dev
, where we could push releases to the dev-npm package, in case you want to test a few things. (I think it's not set up yet, I will need to look into its github/workflows
.)
Otherwise, feel free to create a npm package and call it whatever you want, in case you want to test things on your own. Until I get the time to properly look into this and set up the github/workflows
for pushing to npm on the dev repository.
Once again, thank you so much for the time and effort you are putting into this!!
@dev-xo: Revised PR based on your review, update docs, and added migration guide. Please review and let me know how you want to proceed.
This was a fantastic rework, @mw10013! You also made it look so simple. I want to review the project in my editor, and after that, I think we could push the npm package to v2, create the Release, etc.
Not sure if you had the chance to test it on any of the templates. If you are up for it, I could push remix-auto-totp-dev
to v2 on npm, and we could also test that everything works as expected on the templates (it should, tests pass).
Let me know about that.
@dev-xo: If you are able to push remix-auto-totp-dev
, I'll update and test totp-starter-example and remix-auth-totp-cloudflare-example.
Sounds good to me, @mw10013! I will. I also need to update the other templates and the main totp.fly.dev
website repository, but that runs on my side, so there's nothing to worry about. You've done more than enough already!
v2
published on remix-auth-totp-dev
@mw10013 in case you want to give it a try on the templates! Also, this PR is ready to be merged too.
Not sure if we have to discuss anything more, but I will wait a bit in case you want to try the package on the starter template.
P.S: I was trying to reply to you on Discord, but I'm getting this message: "Your message could not be delivered. This is usually because you don't share a server with the recipient or the recipient is only accepting direct messages from friends."
I think we both share the Remix server, and I also have you added as a friend. Who knows what could be going on.
Again, thanks a lot for this fantastic work!
@dev-xo: I've added more tweaks to the docs in this PR based on testing remix-auth-totp-dev
. totp-starter-example
and remix-auth-totp-cloudflare-example
both have next
branches that work with remix-auth-totp-dev
. v2 is ready to go live from my perspective.
Amazing, so V2 is ready! I will do the required steps later today, and by tomorrow we should have it operational. Again, many thanks for the mind-blowing efforts and the time invested in this, @mw10013!
Merry Christmas to you!
Closes #35 [ Refactor ] Decomplect handleTOTP() API
This refactor addresses the application API for totp data storage by
Totp data is ephemeral since it expires after some time. Session data is also ephemeral and this PR mimics Remix's API for session storage (https://remix.run/docs/en/main/utils/sessions#createsessionstorage).
Conveying expiresAt during create and update simplifies implementation using key-value stores where expiresAt may be metadata.
@dev-xo: Please let me know if you want to move forward with this PR and I'll incorporate any feedback, update README, and add migration notes since breaking change. It would also be helpful to have a dev version in npm for further testing with totp-starter-example and remix-auth-totp-cloudflare-example. And I'm open to learning how to deploy dev versions.