search

dev-xo / remix-auth-totp

A Time-Based One-Time Password (TOTP) Authentication Strategy for Remix-Auth.
https://totp.fly.dev
MIT License
418 stars 28 forks source link

[ Request ] Pass along AppLoadContext during authentication. #50

Closed vrish88 closed 7 months ago

vrish88 commented 7 months ago

In the remix-auth/strategy there is a context param that is intended to be passed to the strategy. This PR merely passes along the context along from authenticator.authenticate(..., ..., {context: appLoadContext}) to the sendTOTP and verify functions.

dev-xo commented 7 months ago

Hello @vrish88, thanks for opening the PR.

remix-auth-totp is currently on stand-by, as the strategy is working as expected and there are no plans to improve or modify it for now.

If you need the context for anything else personally, let us know the reasons for it, or how context could affect/improve the Strategy itself, more than "to be intended to be passed to the strategy".

Would love to hear more about it, Daniel.

dev-xo commented 7 months ago

Closing this for now as the OP seems to not be active on the opened issue.