search

dev-xo / remix-auth-totp

A Time-Based One-Time Password (TOTP) Authentication Strategy for Remix-Auth.
https://totp.fly.dev
MIT License
418 stars 28 forks source link

[ Fix ] Node v20 - Migrate to `base32Encode`. #70

Closed kldeb closed 3 months ago

kldeb commented 3 months ago

Solves node v20 issue running on aws lambda

dev-xo commented 3 months ago

Thanks for the PR, @kldeb.

I noticed some indentation we do not have in the project. Not sure if you can run npm run format in order to fix that. Also, hopefully, @mw10013 could also take a look at the PR too.

kldeb commented 3 months ago

strange, i did run the format script.

dev-xo commented 3 months ago

All right, nothing to worry about @kldeb.

Not sure if we will need some small tests of the base32Encode or if we had those for thirty-two; in any case, let's wait for @mw10013 to share some thoughts, and we will merge it!

dev-xo commented 3 months ago

We will need to bump @epic-web/totp to the new version, right? Let us know what pending changes need to be made in order for us to also merge this and publish a new version of remix-auth-totp, @kldeb.

Also, thanks for the efforts and the improvements!

kldeb commented 3 months ago

@dev-xo Done. I ran pnpm upgrade on the project so there are a few updates (let me know if this is not ok). All tests pass, ran format, lint, typecheck as well.

mw10013 commented 3 months ago

@kldeb Thanks for the PR! Looks good from my side.

dev-xo commented 3 months ago

Merged and published. Let me know if everything works as expected, @kldeb. Again, thanks for the time spent and the efforts!

kldeb commented 3 months ago

@dev-xo thanks! Just tested it and it works!

dev-xo commented 3 months ago

Happy to hear that, @kldeb! Thanks for the PR. Feel free to suggest anything else or come up with some other features/improvements!