search

dev-xo / remix-saas

A Lightweight, Production-Ready Remix Stack for your next SaaS Application.
https://remix-saas.fly.dev
MIT License
1.24k stars 88 forks source link

[ Request ] Add Playwright Testing #239

Closed HananoshikaYomaru closed 2 weeks ago

HananoshikaYomaru commented 5 months ago

refer to :

  1. https://github.com/sergiodxa/remix-auth/blob/main/test/authorizers.test.ts
  2. https://github.com/sergiodxa/remix-auth/discussions/166
dev-xo commented 5 months ago

Hello @HananoshikaYomaru.

I noticed you also commented on #232. It would have been great if you could have referred to that issue here.

Currently, I'm a bit busy, so I'm not sure if I will be available to look into this right now.

Thanks.

HananoshikaYomaru commented 5 months ago

it is not to test the authentication library. it is to test my system authentication is done correctly. For example I want to test the login flow using playwright ui mode. I also want to test features that require authentication and make sure auth protection are working now and in the future (regression testing), in case of me accidentially remove the auth or do some stupid thing etc.

dev-xo commented 5 months ago

It's hard to know what you're looking for without a proper explanation of the issue, @HananoshikaYomaru.

Please take your time to explain exactly what you're looking for. For example:

We can't understand the issue without a proper explanation. You're also referencing two links that don't explain your current issue but instead show some examples.

Thanks.