search

dev-yakuza / react-native-image-modal

the simple image modal for React Native
https://dev-yakuza.github.io/en/react-native/react-native-image-modal/
MIT License
551 stars 46 forks source link

Bug when closing #249

Closed MrNapcae closed 5 months ago

MrNapcae commented 5 months ago

When closing, the image overlaps other blocks from the top and bottom. How can I fix this behavior? I have attached a video.

https://github.com/dev-yakuza/react-native-image-modal/assets/42024544/84ab183f-2ecd-4c4e-bfea-e70deee29196

dev-yakuza commented 5 months ago

@MrNapcae Could you give the sample code for this issue?

MrNapcae commented 5 months ago

@MrNapcaeНе могли бы вы дать пример кода для этой проблемы?

Example сode RN

MrNapcae commented 5 months ago

I looked through the codebase a bit and found out why this behavior is occurring: it's because Modal (react-native) is being used, and it positions itself above everything else, including FlatList. So, to achieve the same result, do we need to abandon Modal? Or are there other possible solutions? I would appreciate any help.

dev-yakuza commented 5 months ago

@MrNapcae Thanks for the information. I will take a look.

dev-yakuza commented 5 months ago

@MrNapcae

I'm almost close to fix the issue.

https://github.com/dev-yakuza/react-native-image-modal/assets/42969906/15e78bfc-1af6-41f1-85ca-c31d5792b0fa

I will refactor the code and release asap.

MrNapcae commented 5 months ago

@MrNapcae

Я почти близок к решению проблемы.

default.mov Я проведу рефакторинг кода и выпущу его как можно скорее.

This is wonderful, many thanks!