search

dev-zzo / kiwiclient

9 stars 40 forks source link

test of new IQ data mode #1

Closed jks-prv closed 7 years ago

jks-prv commented 7 years ago

Don’t expect you to actually merge this. But is shows a new feature of v1.91: how to set the mode to ‘iq’ to receive uint16_t I&Q data.

The “self.set_name('kiwifax’)” you already know about.

dev-zzo commented 7 years ago

Hi John, thanks for your effort on this project, I appreciate it much. I have used your example to make necessary changes in the client as well as the fax code; at the moment, it doesn't work correctly -- apparently, IQ samples need their own baseband filtering, so I will implement that first.

jks-prv commented 7 years ago

Looks like I made a mistake. I had intended to run the IQ samples through the passband filter. I did apply the AGC to them. I will fix this for today’s release. If you think there is any advantage to having unfiltered samples available I could make that an option.

On Jun 6, 2017, at 7:33 PM, Dmitry Janushkevich notifications@github.com wrote:

Hi John, thanks for your effort on this project, I appreciate it much. I have used your example to make necessary changes in the client as well as the fax code; at the moment, it doesn't work correctly -- apparently, IQ samples need their own baseband filtering, so I will implement that first.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dev-zzo/kiwiclient/pull/1#issuecomment-306406022, or mute the thread https://github.com/notifications/unsubscribe-auth/AFg_G-GzCBFcY3A-MDSINZZEXgSG4_6Eks5sBQDDgaJpZM4Nwj9O.

jks-prv commented 7 years ago

Well, I take that back. It looks like the IQ samples I send go through the fast FIR passband filter and then the AGC. So I’m not quite sure what’s wrong.

On Jun 7, 2017, at 8:15 AM, jks@jks.com wrote:

Looks like I made a mistake. I had intended to run the IQ samples through the passband filter. I did apply the AGC to them. I will fix this for today’s release. If you think there is any advantage to having unfiltered samples available I could make that an option.

On Jun 6, 2017, at 7:33 PM, Dmitry Janushkevich <notifications@github.com mailto:notifications@github.com> wrote:

Hi John, thanks for your effort on this project, I appreciate it much. I have used your example to make necessary changes in the client as well as the fax code; at the moment, it doesn't work correctly -- apparently, IQ samples need their own baseband filtering, so I will implement that first.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dev-zzo/kiwiclient/pull/1#issuecomment-306406022, or mute the thread https://github.com/notifications/unsubscribe-auth/AFg_G-GzCBFcY3A-MDSINZZEXgSG4_6Eks5sBQDDgaJpZM4Nwj9O.

dev-zzo commented 7 years ago

That is my impression as well, that the samples go through the FIR... but I don't really see the effect of it when taking the FFT of the samples.

dev-zzo commented 7 years ago

OK, I've figured this out -- the bug was on my side; see commit 61a320a for details. :-) With the latest changes in the code, both audio and IQ samples are usable with results being almost identical in quality.

Thanks again! Closing this PR for now.