search

dev-zzo / kiwiclient

9 stars 40 forks source link

Geo-location on KiwiSDR #3

Open ka7u opened 6 years ago

ka7u commented 6 years ago

This Kiwirecorder.py is very nice! Thank you! So this makes it look like I'm in Antarctica when I use the recorder.

grep -nri antarctica .

./kiwifax.py:372: self.set_geo('Antarctica') ./kiwirecorder.py:46: self.set_geo('Antarctica')

So I can edit it to show KA7U for my call sign, but I wonder if the recorder might use another method to determine geo-location? Ron KA7U

dev-zzo commented 6 years ago

Hi Ron,

I am happy to hear that someone finds use for this script besides me.

As for the location, it can easily be made a command line option so you don't have to edit it manually each time. Throwing in a GeoIP database querying would be too much work for this, I believe.

If you are willing to submit a pull request, please do.

ka7u commented 6 years ago

I'm not prepared to pull and submit changes to this code. Wish I was! Ron - KA7U

jks-prv commented 6 years ago

I think I have fixed this problem. There was a bug in the Kiwi code that does a geolocation lookup on the connecting ip source address. The lookup would fail randomly base on the value of an uninitialized stack variable, so the behavior was unpredictable.