dev1abhi / Flutter-Animations

We are trying to make a flutter app, which has example of every flutter animation available. Currently has 11+ unique animations.
MIT License
12 stars 15 forks source link

Added Flutter water drop effect. #13

Closed bidur0123 closed 1 year ago

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Hey there! I've analyzed the changes made in the pull request and here's the report for you:

Changes

  1. Added water_drop_effect.dart file in the lib/Screens directory.
  2. Imported WaterDropEffect class in drawercontroller.dart file.
  3. Added Water Drop Effect menu item in menuscreen.dart file.

Suggestions

I have a few suggestions to improve the code:

  1. In water_drop_effect.dart:
    • Line 5: Instead of const WaterDropEffect({super.key});, it should be const WaterDropEffect({Key? key}) : super(key: key);.
    • Line 7: Consider adding a const keyword before Scaffold to make it a constant widget.
    • Line 9: Add a space after the comma in Column( for better readability.
    • Line 11: Consider adding a comment to describe the purpose of the Spacer widget.
    • Line 14: Instead of const BoxDecoration(, it should be const BoxDecoration(.
    • Line 15: Add a space after the comma in BoxShape.circle, for better readability.
    • Line 16: Consider adding a comment to describe the purpose of the Container widget.
    • Line 18: Instead of const BoxDecoration(, it should be const BoxDecoration(.
    • Line 19: Add a space after the comma in BoxShape.circle, for better readability.
    • Line 20: Consider adding a comment to describe the purpose of the Container widget.
    • Line 23: Instead of const BoxDecoration(, it should be const BoxDecoration(.
    • Line 24: Add a space after the comma in BoxShape.circle, for better readability.
    • Line 25: Consider adding a comment to describe the purpose of the Container widget.
    • Line 28: Instead of const BoxDecoration(, it should be const BoxDecoration(.
    • Line 29: Add a space after the comma in
bidur0123 commented 1 year ago

I have pushed updated code please merge my code

dev1abhi commented 1 year ago

Reviewed and merged. thanks for contributing. ✨