dev1abhi / Flutter-Animations

We are trying to make a flutter app, which has example of every flutter animation available. Currently has 11+ unique animations.
MIT License
12 stars 15 forks source link

Animated Dialog Box Added #23

Closed Imsurajr closed 1 year ago

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Greetings!

Hey there! I've analyzed the changes made in the pull request and here's the report for you. Let's dive in!

Changes

  1. Added import '../Screens/animated_dialog.dart'; in lib/Controllers/drawercontroller.dart at line 9.
  2. Added class AnimatedDialog in lib/Screens/animated_dialog.dart at line 7.
  3. Added State<AnimatedDialog> in lib/Screens/animated_dialog.dart at line 11.
  4. Added build method in lib/Screens/animated_dialog.dart at line 14.
  5. Added Scaffold widget in lib/Screens/animated_dialog.dart at line 16.
  6. Added AppBar widget in lib/Screens/animated_dialog.dart at line 18.
  7. Added IconButton widget in lib/Screens/animated_dialog.dart at line 23.
  8. Added ElevatedButton widget in lib/Screens/animated_dialog.dart at line 32.
  9. Added showGeneralDialog method in lib/Screens/animated_dialog.dart at line 34.
  10. Added Transform.rotate widget in lib/Screens/animated_dialog.dart at line 54.
  11. Added AlertDialog widget in lib/Screens/animated_dialog.dart at line 55.
  12. Added transitionDuration property in lib/Screens/animated_dialog.dart at line 79.

Suggestions

  1. It's a good practice to follow consistent naming conventions for files and classes. Consider renaming animated_dialog.dart to animated_dialog_screen.dart for better readability.

Bugs

No bugs found.

Improvements

  1. In lib/Controllers/drawercontroller.dart, consider organizing the case statements in the switch block using indentation for better readability. Here's the improved code snippet:
switch (selectedMenuItem) {
  case 0:
    return mainScreen1;
  case 1:
    return mainScreen2;
  case 2:
    return mainScreen3;
  case 3:
    return mainScreen4;
  case 4:
    return mainScreen5;
  case 5:
    return mainScreen6;
  case 6:
    return mainScreen7;
  case 7:
    return mainScreen8;
  // Add more cases when you are adding new screen
  default:
    return mainScreen1; // Default to mainScreen1 if the selection is not recognized
}

Rating

I would rate the code 8 out of 10 based on the following criteria:

That's it for the report! If you have any questions or need further assistance, feel free to ask. Happy coding!

dev1abhi commented 1 year ago

Accepted and merged.

Imsurajr commented 1 year ago

Hey @dev1abhi it shows not accepted on hacktoberfest website? image

dev1abhi commented 1 year ago

Hey @dev1abhi it shows not accepted on hacktoberfest website? image

It will be reflected after 15 mins or so.