dev1abhi / Flutter-Animations

We are trying to make a flutter app, which has example of every flutter animation available. Currently has 11+ unique animations.
MIT License
12 stars 15 forks source link

added SplashScreen with LottieAnimation #6

Closed Srujithchaithanya1 closed 1 year ago

Srujithchaithanya1 commented 1 year ago

I have added the Lottie Animation json file and used as the SplashScreen

pr-explainer-bot[bot] commented 1 year ago

Pull Request Review Summary

Hey there! 👋 Here's a summary of the previous tasks and their results for the pull request review. Let's dive in!

Changes

  1. Added a new file FlutterAnimation.json in the assets directory. 📁

Suggestions

  1. Line 1: Instead of /dev/null, consider using a more descriptive file path or name. 🤔
  2. Line 2: The JSON object should be properly formatted with indentation for better readability. 📝
  3. Line 3: The @@ symbol is not necessary and can be removed. 🚫
  4. Line 4: The + symbol before the JSON object is not needed and can be removed. ➖

Bugs

  1. Potential bug: The assets array in the JSON object seems to be missing a closing square bracket (]). 🐛

Improvements

  1. In the FlutterAnimation.json file, the assets array can be refactored for better readability by using a more structured format. Here's an example:
    "assets": [
     {
       "id": "image_0",
       "w": 182,
       "h": 225,
       "u": "",
       "p": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAALYAAADhCAYAAABle09LAAAL1UlEQVR4Xu3dz29cVxXA8ftmnDiGBYUFO9RIiAUbiAQIFQsUkBBsQJHaimbVRChrypJ/gB1SVyABEq5QIcgVSdoCc

    Please make sure to update the file accordingly. 🛠️

Rating

Based on the criteria of readability, performance, and security, please rate the code from 0 to 10. Feel free to provide a brief explanation. 🌟

That's it for the summary! If you have any questions or need further clarification, feel free to ask. Good luck with the pull request! 🚀

dev1abhi commented 1 year ago

Accepted & Merged. :)