Closed LS-FCEFyN closed 11 months ago
It's worth noting that at this point droidcam's own v4l2loopback-dc
is not implemented.
Yeah this looks good, and will also close #189.
#!/usr/bin/env bash
is fine, thats a common pattern
v4l2loopback-dc
being missing is fine, its an old fork and is likely to be dropped eventually.
Just some whitespace nitpicks
Makefile
and the README
, could we clear those upifeq
scope so the =
signs are in the same column##
heading in the READMESorry it took me this long to get back at you, everything should be in order now.
Thanks, the changes have been added to the main repo
I did some modifications to some files, namely:
For those files above I added the necessary includes
All the installation and uninstallation scripts had their first line modified from
to
Since in FreeBSD bash is third-party software and thus is located at /usr/local/bin/bash not /bin/bash
I reckon that using:
Might not be the best way to achieve "portability" due to some problems see this, but those problems did not arise in my machine, neither on Arch, Debian, FreeBSD nor NomadBSD (a FreeBSD "distro"). If problems do arise in any other distros the line could be modified to be:
Or FreeBSD users could just make a symbolic link and keep the original line from your install scripts.
Naturally the Makefile was also modified.
The Readme.md was also modified to have instructions on how to build the package on FreeBSD.