Open romper008 opened 4 years ago
Getting similar issues here. Clique sometimes stops working when this addon is enabled. Rebinding one spell in Clique fixes it for a while, until it breaks again. Not sure what´s up.
The author of Clique isn't sure what Blizzard Raid Frames Fix is doing exactly, so isn't sure how this could be fixed. See the dev's comment here: https://www.wowinterface.com/downloads/fileinfo.php?id=5108#comments
Would you mind chiming in on the conversation @dev7355608 ?
I found the source of the problem and released a fix. Hopefully that does the trick. Let me know.
Will test this afternoon after work. Will give feedback as soon as I have tested it. Thank you very much!
Hmmm, it seems to work fine with no real issues, except I am getting a ton of LUA errors while mouse overing the raid frames after this update. Bugsack has seen a total of 293 times the following error. Not sure if this is helpful in any way? Again, I am not experiencing any downsides to these errors. But there are happening constantly.
293x C stack overflow
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:345: in function <FrameXML\SecureHandlers.lua:330>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:266: in function <FrameXML\SecureHandlers.lua:263>
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:345: in function <FrameXML\SecureHandlers.lua:330>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:266: in function <FrameXML\SecureHandlers.lua:263>
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:345: in function <FrameXML\SecureHandlers.lua:330>
...
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:266: in function <FrameXML\SecureHandlers.lua:263>
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:345: in function <FrameXML\SecureHandlers.lua:330>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:266: in function <FrameXML\SecureHandlers.lua:263>
[string "=[C]"]: ?
[string "@FrameXML\SecureHandlers.lua"]:345: in function <FrameXML\SecureHandlers.lua:330>
[string "=(tail call)"]: ?
Locals:
(*temporary) = <function> defined =[C]:-1
(*temporary) = <function> defined @FrameXML\SecureHandlers.lua:263
(*temporary) = CompactRaidFrame31 {
0 = <userdata>
debuffFrames = <table> {
}
displayedUnit = "raidpet23"
maxDispelDebuffs = 0
inUse = true
inVehicle = false
background = CompactRaidFrame31Background {
}
powerBar = CompactRaidFrame31PowerBar {
}
healthBar = CompactRaidFrame31HealthBar {
}
overAbsorbGlow = CompactRaidFrame31OverAbsorbGlow {
}
horizTopBorder = CompactRaidFrame31HorizTopBorder {
}
vertRightBorder = CompactRaidFrame31VertRightBorder {
}
myHealPrediction = CompactRaidFrame31MyHealPrediction {
}
dropDown = CompactRaidFrame31DropDown {
}
myHealAbsorbRightShadow = CompactRaidFrame31MyHealAbsorbRightShadow {
}
overHealAbsorbGlow = CompactRaidFrame31OverHealAbsorbGlow {
}
newUnit = true
hasValidVehicleDisplay = false
selectionHighlight = CompactRaidFrame31SelectionHighlight {
}
onUpdateFrame = <unnamed> {
}
myHealAbsorbLeftShadow = CompactRaidFrame31MyHealAbsorbLeftShadow {
}
totalAbsorbOverlay = CompactRaidFrame31TotalAbsorbOverlay {
}
unit = "raidpet23"
unitExists = false
unusedFunc = <function> defined @Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua:46
statusText = CompactRaidFrame31StatusText {
}
horizDivider = CompactRaidFrame31HorizDivider {
}
roleIcon = CompactRaidFrame31RoleIcon {
}
applyFunc = <function> defined @Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua:324
menu = <function> defined @FrameXML\CompactUnitFrame.lua:261
otherHealPrediction = CompactRaidFrame31OtherHealPrediction {
}
optionTable = <table> {
}
buffFrames = <table> {
}
centerStatusIcon = CompactRaidFrame31CenterStatusIcon {
}
maxDebuffs = 0
dispelDebuffFrames = <table> {
}
myHealAbsorb = CompactRaidFrame31MyHealAbsorb {
}
maxBuffs = 0
vertLeftBorder = CompactRaidFrame31VertLeftBorder {
}
horizBottomBorder = CompactRaidFrame31HorizBottomBorder {
}
name = CompactRaidFrame31Name {
}
readyCheckIcon = CompactRaidFrame31ReadyCheckIcon {
}
totalAbsorb = CompactRaidFrame31TotalAbsorb {
}
}
(*temporary) = <function> defined @FrameXML\SecureHandlers.lua:199
(*temporary) = true
So, the error spam seems random and doesn't seem to affect anything at all, really. A /reload usually fix it. I had some time to raid yesterday, and there was one issue still present:
If we do a group swap mid combat for bloodlust, mouseover healing via Clique doesn't work correctly anymore. We had a tank A in group 1 and a shaman B in group 2. When he swapped them around mid combat, healing A would heal B instead and vice versa. Targetting by clicking them still seemed to work fine. Is this a bug with this addon as well? Or would this be an issue elsewhere?
When addon enabled(BlizzRaidFrameFix) Clique full keyboard binds(for example: SHIFT+Q or SHIFT+F5) don't work for Blizzard Raid Frames but binds like SHIFT+LMB or CTRL+MouseButton4 work properly. No LUA errors or something so I don’t know which side is the problem: Clique or BlizzRaidFrameFix.