search

dev7355608 / BlizzardRaidFramesFix

This addon prevents the Blizzard raid frames from breaking when players join or leave during combat in WoW
https://www.curseforge.com/wow/addons/blizzardraidframesfix
MIT License
2 stars 4 forks source link

Clique: Swapping members mid-combat #2

Open Mushoz opened 3 years ago

Mushoz commented 3 years ago

In classic, members are often switched from group to group in order to benefit multiple times from bloodlust / heroism. This addon doesn't seem to take this into account by queuing it up and executing the changes after combat has ended, like it does with other changes (such as people joining/leaving).

When a member is switched in combat, with or without this addon, the two switched members are now also switched when using Clique to mouseover heal. For example, if person A is swapped with person B, mouseover healing A will heal B instead and vice versa. This has let me to spam heal a random shaman over the tank multiple times now, which sometimes ends badly :)

dev7355608 commented 3 years ago

I'm not sure if the Clique compatibility issue will be ever resolved or if it is actually possible.

Mushoz commented 3 years ago

It's not a compatibility issue though, since it's also happening when Blizzard Raid Frames Fix is disabled. As far as I understand this correctly, any action that is done during combat which would result in illegal API access is queued up by this Addon, and then executed AFTER combat, correct? So for example, if a new member joins the raid during a fight, it will simply not show up, until after combat.

Swapping members obviously runs into similar issues as adding members is, so wouldn't we be able to solve this in the same way? Eg, if members are swapped during combat, the raid frames will simply not reflect those changes and queue these changes up. Once combat ends, the visual changes are applied to the raid frames.

dev7355608 commented 3 years ago

I'm a little confused now: If Blizzard Raid Frames Fix is enabled, the layout of the frames should not change (or break) in combat; only after combat ends. It should work with group swapping as well. Is that working (with Clique disabled)? I thought the frames worked properly, and only Clique macros break.