devBanner / devBanner_Frontend

Responsive web page for devBanner (WEB)
https://devbanner.center
Apache License 2.0
10 stars 8 forks source link

Add custom width feature #38

Closed cozyplanes closed 6 years ago

cozyplanes commented 6 years ago

https://github.com/devBanner/devBanner/pull/43

It adds &width=[128 ~ 2048 number here] at the end of the request url

jonasgeiler commented 6 years ago

Wtf does [128 ~ 2048 number here] mean???

jonasgeiler commented 6 years ago

Will do as soon as possible

cozyplanes commented 6 years ago

@skayo it adds a value (width) Such as

&width=128
&width=245
&width=648
&width=800
And all the way to 
&width=2048
jonasgeiler commented 6 years ago

Okay and should I do a slider or a drop down or just a number input?

cozyplanes commented 6 years ago

Slider  with a small textbox in the right would be nice

cozyplanes commented 6 years ago

@skayo can the current image preview handle smaller/bigger images??

jonasgeiler commented 6 years ago

Not really. The loading thing would probably be off center

cozyplanes commented 6 years ago

@skayo the backend code has heen updated, just need to deploy the front end

jonasgeiler commented 6 years ago

I currently don't have time to do it, will do asap

cozyplanes commented 6 years ago

Np Take your time Btw do you think black font is better than white font in yellow bg?

jonasgeiler commented 6 years ago

heh. good question... Would need an example for that but it definitely depends on the font weight

cozyplanes commented 6 years ago

@Skayo https://devrant.com/rants/1456230

jonasgeiler commented 6 years ago

Oh okay, thanks. Yeah white is definitely better

cozyplanes commented 6 years ago

@Skayo umm it seems you forgot PR to master (devBanner org)

cozyplanes commented 6 years ago

The margin in the right is a bit...... Strange

I am using S8 with curved edges tho

jonasgeiler commented 6 years ago

shh

jonasgeiler commented 6 years ago

will fix asap

jonasgeiler commented 6 years ago

Look #39