Open KushtrimPacaj opened 7 years ago
I believe we did this on purpose. What is the behavior of most apps? The tabs felt a lot more responsive this way I think.
The standard behavior for an Android app would be when the user pressed the tab, and lifts the finger while inside it. This would trigger the onClickListener in a button.
On Thu, Aug 3, 2017, 4:28 AM David Fox notifications@github.com wrote:
I believe we did this on purpose. What is the behavior of most apps? The tabs felt a lot more responsive this way I think.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/devRant/devRant/issues/18#issuecomment-319850585, or mute the thread https://github.com/notifications/unsubscribe-auth/AIIL2GsqjJWrcy1LPdluSG5n9uYsoEx4ks5sUTA1gaJpZM4Oqsxb .
Should be onRelease (or whatever equivalent). I'm testing on my android Pixel right now, and not seeing any immediate reaction to a tap, only after I lift my finger. Especially telling is that if I tap on a tab on a far left or right edge and drag my finger off the screen, that tab is not activated.
I'm doing this on my Pixel XL, latest version of the app. Here's a demo video : https://youtu.be/1iWMVwBxj-U
@KushtrimPacaj ah, I was thinking the text tabs like for sort and on profile, not the nav bar tabs. Yeah, those bottom nav tabs shouldn't be behaving like that
just to mention again, please fix this as soon as possible. This is annoying as hell in phones with the home keys in the screen
If you press down on the tab, it immediately registers that as click. It doesn't function as a proper onClick, since that would require lifting the finger.
Because of this, I end up switching tabs by mistake