search

devacfr / reflow-maven-skin

Reflow is an Apache Maven site skin built on Bootstrap. It allows various structural and stylistic customizations to create a modern-looking Maven-generated website.
http://devacfr.github.io/reflow-maven-skin/
Apache License 2.0
8 stars 3 forks source link

TOC issues for headers with same labels #14

Closed solomax closed 6 years ago

solomax commented 6 years ago

The following configurations will fail:

Carousel is enabled:

<section name="Test"></section>
<hr/>
<section name="Features">
    <subsection name="Test"></subsection>
</section>

In this case second Test will be listed in TOC, but will not be hightlighted, and will not move to correct part of the page

Carousel is disabled

<section name="Test1">
    <h3 name="Prerequicite"></h3>
    <h3 name="Steps"></h3>
</section>
<section name="Test2">
    <h3 name="Prerequicite"></h3>
    <h3 name="Steps"></h3>
</section>

Will display correct TOC, but all links from Test2->h3* will point to Test1->h3*

devacfr commented 6 years ago

See commit https://github.com/devacfr/reflow-maven-skin/commit/2a52356119170bce9a8e5e19219d88bf251a520b for check.

Best regards,

solomax commented 6 years ago

Seems to work as expected! Thanks for the quick fix!

devacfr commented 6 years ago

do you want publish a snapshot on https://oss.sonatype.org/content/repositories/snapshots/ ?

solomax commented 6 years ago

I have tested using local build Will wait for release :)

devacfr commented 6 years ago

I can produce for this day ?!

solomax commented 6 years ago

I have renamed TOC items for now. So no rush :) Let the release has #15 implemented Without floated sidebar no-one will notice this issue :)

devacfr commented 6 years ago

👍