devacfr / reflow-maven-skin

Reflow is an Apache Maven site skin built on Bootstrap. It allows various structural and stylistic customizations to create a modern-looking Maven-generated website.
http://devacfr.github.io/reflow-maven-skin/
Apache License 2.0
8 stars 3 forks source link

Source highlighting seems to be broken #41

Closed solomax closed 5 years ago

solomax commented 5 years ago

Hello @devacfr,

I'm using latest 2.0.0beta2 and just noticed source highlighting seems to be broken I'm using xdoc format and blocks like this <source><![CDATA[]]></source>

This result can be checked here: https://builds.apache.org/view/M-R/view/OpenMeetings/job/OpenMeetings%204.0.x/site/openmeetings-server/RTMPSAndHTTPS.html

Same page generated with 1.4.2 available here: https://om.alteametasoft.com/openmeetings/docs/RTMPSAndHTTPS.html

Shall I add custom styles, or maybe something wrong with generation?

solomax commented 5 years ago

This issue is fixed after adding

    <highlightJs>true</highlightJs>
    <highlightJsTheme>github</highlightJsTheme>

and unpacking correspondent stylesheet So I guess only users not using highlightJs are affected

devacfr commented 5 years ago

Hello @solomax, I hope you have a good Christmas Eve. Can I close this issue?

solomax commented 5 years ago

Sure, if <source> shouldn't work without highlightJs :)

Merry Christmas :) In Russia main hioliday is NY :) and Christmas is being celebrated Jan 7 :)))