devadvance / terminalcheatsheet

All the knowledge you need to get up and running on terminals across operating systems. If you are contributing to open issue on this repo, please ask to be assigned to the issue so people know you are working on it.
https://terminalcheatsheet.com
Apache License 2.0
21 stars 26 forks source link

Create a Indonesian translation of the curl REST API guide #117

Closed devadvance closed 4 years ago

devadvance commented 4 years ago

Based on the English version of the guide (https://github.com/devadvance/terminalcheatsheet/blob/staging/guides/curl-rest-api.md), create a Indonesian translation in https://github.com/devadvance/terminalcheatsheet/blob/staging/i18n/id/guides/curl-rest-api.md.

It is OK to use the English images/GIFs. Look for TODO in the file for suggested places for translations.

Please comment on this issue before starting work so people are informed that you are working on it.

Aldhanekaa commented 4 years ago

may I work on this translation?

devadvance commented 4 years ago

@Aldhanekaa sure! Assigned to you.

Aldhanekaa commented 4 years ago

Screen Shot 2020-10-05 at 05 58 05 Is the AMP validation had errors because of the Http address?

but after opening Learn more they guide me to change something in code. I shouldn't do that, right?

Is the problem will solve when the site doesn't have Http address (Using GitHub page)?

Aldhanekaa commented 4 years ago

Screen Shot 2020-10-05 at 05 58 05 Is the AMP validation had errors because of the Http address?

but after opening Learn more they guide me to change something in code. I shouldn't do that, right?

Is the problem will solve when the site doesn't have Http address (Using GitHub page)?

Actually I already translated it, but doubt to pull request because of that error.

devadvance commented 4 years ago

@Aldhanekaa that error is fine. During local development, the content is http instead of https. If there are no other errors, then it is ready for PR!

Aldhanekaa commented 4 years ago

139

devadvance commented 4 years ago

Reviewed and merged. Thanks for contributing!!