search

devandanger / RxJTAppleCalendar

Rx extension for the JTAppleCalendar
MIT License
0 stars 0 forks source link

RxJTAppleCalendar #1

Open patchthecode opened 7 years ago

patchthecode commented 7 years ago

is it impossible to do? or is there anything needed to be done to the code to make it possible?

devandanger commented 7 years ago

Not currently possible actually due to lack of rxswift support for pure swift protocols. However there is an issue / PR out there to solve it so I was planning to come back to this repo.

Would this be something you’d be interesting in accepting as a PR in your repo? Would be implemented as a subspec.

patchthecode commented 7 years ago

I'd be interested in accepting.

I'm not a rxSwift expert; would there be any changes made to the swift library code?

Also, have you got a link to the PR? I didnt know there was one yet. Would love to get a look for my other swift projects. Thanks man.

devandanger commented 7 years ago

I don't think so at this point. The following PR has been accepted by the RxSwift team here. https://github.com/ReactiveX/RxSwift/pull/1465

So the work in order to implement this is pretty small. If you look at the following Moya.podspec, that's how I was originally thinking of implement it as a subspec. https://github.com/Moya/Moya/blob/master/Moya.podspec

I'll look into implementing this week in your repo though. Nothing concrete as far as PR right now, just some code that I hacked together before realizing it wasn't really possible since RxSwift didn't support "rxswift-ifying" pure swift protocols only ones based on obj-c. Here's an example of the work though... https://medium.com/@sudomax/rxswift-migrate-delegates-to-beautiful-observables-3e606a863048

Again I'll open up a PR in your repo this weekend so you can see what I'm talking about. Excited though, our app relies on rxswift a lot so this would improve our usage of this library.

patchthecode commented 7 years ago

Thanks for the info. Understood.

devandanger commented 7 years ago

I misread some of the commits / issues in the RxSwift last week. The issue blocking from this being possible is still in the design mode. Original issue was closed and the following is discussed here. https://github.com/ReactiveX/RxSwift/issues/1442

Interestingly enough, your library is one of the examples included in the bug. Lot of people interested in that. 👍

I have some of the work completed up to the blocking point here. https://github.com/devandanger/JTAppleCalendar.git . (feature/rxswift-delegates)

patchthecode commented 7 years ago

ok. I understand. Thanks for your work so far in this.

patchthecode commented 5 years ago

its been a while, just wondering :)

I see that issue https://github.com/ReactiveX/RxSwift/issues/1442 is now closed. So i guess that the final verdict is that it is currently impossible?