search

devanlai / dapboot

DFU Bootloader for STM32 chips
Other
337 stars 111 forks source link

Optional high-memory bootloader #24

Closed dmsc closed 4 years ago

dmsc commented 4 years ago

This is my current patch for the option 2 as discussed on pull-request #23

I have not tested all the options, so do not merge yet.

devanlai commented 4 years ago

These changes look pretty good to me from just reading the code. There are some minor typos and additional comments for the linker scripts that I'd eventually like to adjust, but otherwise I don't think this will need any major functional changes. When I get a chance, I will do some sanity testing on this branch with my dev boards.

dmsc commented 4 years ago

Hi!

These changes look pretty good to me from just reading the code. There are some minor typos and additional comments for the linker scripts that I'd eventually like to adjust, but otherwise I don't think this will need any major functional changes.

Just comment the patch here and I can fix the typos and add the comments.

When I get a chance, I will do some sanity testing on this branch with my dev boards.

Today I also plan to test on bluepill and olimexino-stm32.

Have Fun!

dmsc commented 4 years ago

Hi!

Pushed new version. Thanks!

devanlai commented 4 years ago

Thanks, I've merged your changes. Great work!