search

devanlai / dapboot

DFU Bootloader for STM32 chips
Other
337 stars 111 forks source link

PR of `usbd_register_extra_string` commit from devanlai/libopencm3? #8

Closed karelbilek closed 6 years ago

karelbilek commented 6 years ago

Hello,

would you consider adding PR from your fork of devanlai/libopencm3 to upstream?

It would be helpful to have the usbd_register_extra_string in upstream!

I don't want to add that, since it's your code.

(I thought this is on the main repo, but that's actually a github bug that shows forks wrong. :( https://github.com/libopencm3/libopencm3/commit/90be02008e6b651ce737019b6b39ddfdf85eda6b )

devanlai commented 6 years ago

Hi, there's actually already a PR to upstream usbd_register_extra_string, libopencm3/libopencm3#849. I'm more than happy to let someone else bring it up to libopencm3 standards.

karelbilek commented 6 years ago

Thanks, I could not find it!