search

devanlooches / rocketfetch

A WIP command line system information tool written with multithreading in rust for performance with toml file configuration.
MIT License
10 stars 1 forks source link

Add debian support #5

Closed Odilf closed 7 months ago

Odilf commented 9 months ago

Closes #4.

In this PR I've only added the logo. I thought that was the only thing needed to add support, but it doesn't seem to work. I get an error that fails to get the window manager and desktop environment. I kinda tried to fix it but while doing so I came across pfetch which I sort of prefer because the message is nice and small.

Buuut since I've added the logo then might as well put the PR here 🤷‍♂️ . Instead of doing the thing with the vectors and colors, I just took the output of neofetch, piped it out to a file, added that file to src/logos and inlude_str!ed it. It seems less messy and easier to check if it's correct (since you can just cat the output)

Hope it's useful!

devanlooches commented 7 months ago

Thank you for submitting this pull request! I decided I'm going to replace the rest of the logos using the method you used here. Your switch to pfetch is understandable. Thank you for trying out my creation anyway! As for the errors you got: I have noticed this with windows already for example that certain features are not supported on certain OS. I'm thinking I might change the behavior to just hiding features when they fail to fetch and using a tracer to log a warning when this happens.