Closed t-richards closed 3 years ago
Cool before I merge this I'm just going to pick your brain about how you see github actions playing with Netlify (eg: should I add an action to deploy to Netlify? Is there native support on Netlify's end I'm missing? Do we just use github actions as another build step?).
Other than those minor questions, looks great to me, thanks a ton for these contributions.
@StrangeWill For a site like this, I think the way we should primarily use GitHub Actions is as an additional signal for PR reviews. That is, running tests and linting things that the Netlify build shouldn't worry about. More or less, it should do what Travis CI does for us now; produce a couple extra rows in the "checks" section of this page.
It would be best to leave the deploy process on the Netlify side.
Turned off Travis CI (from what I can tell), it'll get removed with the move to the .com platform I guess.
Preview link
(No significant visual changes should be present as a result of this PR)
https://deploy-preview-278--devanooga.netlify.app/
Summary
Bump lighthouse scores
Post-merge checklist
Other remarks
Please squash merge me! :smile: