devanshukumar / flot

Automatically exported from code.google.com/p/flot
0 stars 0 forks source link

ShadowSize is not implemented #38

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
line 216:

 if (s.shadowSize == null)
     s.shadowSize = options.shadowSize;

should be 

 if (s.shadowSize != null)
     s.shadowSize = options.shadowSize;

Original issue reported on code.google.com by rox.solo...@gmail.com on 21 May 2008 at 10:49

GoogleCodeExporter commented 8 years ago
It is correct the way it is.

s == the current data series

If s.shadowSize is null (aka, the data series does not have a custom 
shadowSize) then
we want to use the default shadowSize in  'options'. If the series does have a
shadowSize, then we want to use it (eg, don't overwrite it with the setting in
'options').

Original comment by ryan.fun...@gmail.com on 28 May 2008 at 3:41

GoogleCodeExporter commented 8 years ago
Thanks for the analysis!

Original comment by olau%iol...@gtempaccount.com on 8 Sep 2008 at 9:25

GoogleCodeExporter commented 8 years ago

Original comment by dnsch...@gmail.com on 4 Jun 2012 at 2:39