search

devartis / passbook

Python library to create Apple Passbook (.pkpass) files
http://www.devartis.com/
MIT License
272 stars 108 forks source link

Add support for Python 3 #43

Closed mbaechtold closed 4 years ago

mbaechtold commented 7 years ago

⚠️ This also drops support for Python 2 since Python 2 is not (officially) maintained anymore.

Closes https://github.com/devartis/passbook/issues/40 and https://github.com/devartis/passbook/issues/49

bimusiek commented 6 years ago

Did anyone try using it on production?

mbaechtold commented 6 years ago

Not me.

bimusiek commented 6 years ago

Thanks for so swift reply, I will try it out and see if there are any issues.

mbaechtold commented 6 years ago

Any feedback would be greatly appreciated.

mbaechtold commented 6 years ago

m2crypto finally released Python 3 support.

frat3rius commented 6 years ago

I think it would be a good practice to leave backward compatibility with python 2. Thanks for moving passbook into python 3. If I encounter any problems I'll report back here.

mbaechtold commented 6 years ago

@Fraterius, thanks for giving it a try.

Python 2 will be maintained until 2020. Until then, we should support it too, yes.

antwan commented 5 years ago

What's blocking this PR?

pablo-moreno commented 4 years ago

Hi, any update on this?

mbaechtold commented 4 years ago

I'm confident that this should work on Python 3 now. I was able to generate a valid PkPass file with real certificates from my Apple developer account.

Could anybody please try it out on their machines by installing the package directly from my fork on GitHub (https://github.com/mbaechtold/passbook/tree/python3-m2crypto)?

⚠️ As discussed in #49, I have also removed support for Python 2.

mbaechtold commented 4 years ago

@fara, I propose to merge this. Are you okay with it?

fara commented 4 years ago

@mbaechtold tried your branch locally and all tests pass. The PR looks good. You should add yourself in the credits section of the README.md file and then go ahead and merge

bartoszhernas commented 4 years ago

GetPassbook.com was using this fork for months with Python3, so I would say it's safe to release :) (learned now after our CI broke due to missing fork branch ;)

mbaechtold commented 4 years ago

Hey @bartoszhernas, thank you very much for reporting in. Glad to hear it is working and helpful to you!